[#CLJ-433] munge should not munge $ (which isJavaIdentifierPart), should munge ' (which is not) - Clojure JIRA

Details

Type: Defect
Status: Closed
Priority: Major
Resolution: Completed
Affects Version/s: None
Fix Version/s: Release 1.3
Component/s: None
Labels:
None

Approval:
Ok

Description

munge is overeager in converting $ to DOLLARSIGN, since $ is a valid
character in Java identifiers:

user> (filter #(Character/isJavaIdentifierPart %) (keys
clojure.lang.Compiler/CHAR_MAP))
(\$)

On a related point, ' (single quote) is not admissible in Java
identifiers, but it is not munged on master:

user=> (Character/isJavaIdentifierPart \')
false
user=> (munge "'")
"'"

This leads to e.g.

user=> *'
#<core$_STAR_' clojure.core$_STAR_'@5adf48c4>

(note the ' after STAR).

Originally reported on the Dev list.

See also this thread on the (regular) Clojure ggroup.

The attached patch applies cleanly against current master.

More Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

0001-fix-munge-handling-of.patch

08/Dec/10 12:12 AM

0.9 kB

Michał Marczyk

Activity

Ascending order - Click to sort in descending order

Stuart Halloway made changes - 30/Oct/10 12:05 PM

Field	Original Value	New Value
Assignee		Rich Hickey [ richhickey ]
Reporter		Assembla Importer [ importer ]
Priority		Major [ 3 ]
Description	munge is overeager in converting $ to _DOLLARSIGN_, since $ is a valid character in Java identifiers: {code}user> (filter #(Character/isJavaIdentifierPart %) (keys clojure.lang.Compiler/CHAR_MAP)) (\$) </code></pre> On a related point, ' (single quote) is not admissible in Java identifiers, but it is not munged on master: <pre><code>user=> (Character/isJavaIdentifierPart \') false user=> (munge "'") "'" </code></pre> This leads to e.g. <pre><code>user=> *' #<core$_STAR_' clojure.core$_STAR_'@5adf48c4> {code} (note the ' after _STAR_). Originally reported [on the Dev list\|http://groups.google.com/group/clojure-dev/browse_thread/thread/9caab13eafa10f80]. See also [this thread\|http://groups.google.com/group/clojure/browse_thread/thread/7753adc5453d7410] on the (regular) Clojure ggroup. The attached patch applies cleanly against current master.	munge is overeager in converting $ to _DOLLARSIGN_, since $ is a valid character in Java identifiers: {code}user> (filter #(Character/isJavaIdentifierPart %) (keys clojure.lang.Compiler/CHAR_MAP)) (\$) {code} On a related point, ' (single quote) is not admissible in Java identifiers, but it is not munged on master: {code}user=> (Character/isJavaIdentifierPart \') false user=> (munge "'") "'" {code} This leads to e.g. {code}user=> *' #<core$_STAR_' clojure.core$_STAR_'@5adf48c4> {code} (note the ' after _STAR_). Originally reported [on the Dev list\|http://groups.google.com/group/clojure-dev/browse_thread/thread/9caab13eafa10f80]. See also [this thread\|http://groups.google.com/group/clojure/browse_thread/thread/7753adc5453d7410] on the (regular) Clojure ggroup. The attached patch applies cleanly against current master.