Clojure

Add default predicate argument to filter, every?, take-while

Details

  • Type: Enhancement Enhancement
  • Status: Open Open
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: Backlog
  • Component/s: None
  • Labels:
    None

Description

Some seq processing functions that take predicates could be improved by the addition of a default value of identity for the predicate argument.

This has been discussed on the mailing list, and people seem favorable:
http://groups.google.com/group/clojure/browse_thread/thread/600559b7ee261908/3bc5d144ac54854e?lnk=gst&q=filter+identity#3bc5d144ac54854e
http://groups.google.com/group/clojure-dev/browse_thread/thread/0a9b5750dd7ec4ca

I can put together a patch.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Assembla Importer added a comment -

Converted from http://www.assembla.com/spaces/clojure/tickets/450

Show
Assembla Importer added a comment - Converted from http://www.assembla.com/spaces/clojure/tickets/450
Hide
Permalink
Jason Orendorff added a comment -

I independently wanted this. Here's a patch for: some, not-any?, every?, not-every?. If this is roughly what's wanted I'll be happy to add filter, remove, take-while, drop-while.

Show
Jason Orendorff added a comment - I independently wanted this. Here's a patch for: some, not-any?, every?, not-every?. If this is roughly what's wanted I'll be happy to add filter, remove, take-while, drop-while.
Jason Orendorff made changes -
Field Original Value New Value
Attachment clojure-default-every-argument-v1.patch [ 10991 ]
Hide
Permalink
Jason Orendorff added a comment -

Note that there are a few cases of (every? identity ...) and (some identity ...) in core.clj itself; the patch removes "identity" from those.

Show
Jason Orendorff added a comment - Note that there are a few cases of (every? identity ...) and (some identity ...) in core.clj itself; the patch removes "identity" from those.
Hide
Permalink
Andy Fingerhut added a comment -

clj-450-add-default-pred-arg-to-core-fns-patch.txt dated Apr 26 2012 is identical to Jason Orendorff's, except it is in git format. Jason is not on the list of Clojure contributors as of today. I have sent him an email asking if he has done so, or is planning to.

Show
Andy Fingerhut added a comment - clj-450-add-default-pred-arg-to-core-fns-patch.txt dated Apr 26 2012 is identical to Jason Orendorff's, except it is in git format. Jason is not on the list of Clojure contributors as of today. I have sent him an email asking if he has done so, or is planning to.
Andy Fingerhut made changes -
Attachment clj-450-add-default-pred-arg-to-core-fns-patch.txt [ 11115 ]
Hide
Permalink
Jason Orendorff added a comment -

Of course I'd be happy to send in a contributor agreement. ...Is there actually any interest in taking this patch or something like it?

Show
Jason Orendorff added a comment - Of course I'd be happy to send in a contributor agreement. ...Is there actually any interest in taking this patch or something like it?
Hide
Permalink
Andy Fingerhut added a comment -

I don't know if there is any interest in taking this patch. Perhaps a Clojure screener will take a look at it and comment, but I am not a screener and can't promise anything.

Show
Andy Fingerhut added a comment - I don't know if there is any interest in taking this patch. Perhaps a Clojure screener will take a look at it and comment, but I am not a screener and can't promise anything.

People

  • Assignee:
    Unassigned
    Reporter:
    Anonymous
Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
Atlassian JIRA (v4.4#649-r158309) | Report a problem
Powered by a free Atlassian JIRA open source license for Clojure. Try JIRA - bug tracking software for your team.