[#CLJ-693] VerifyError with symbol metadata, macros, and defrecord - Clojure JIRA

Details

Type: Defect
Status: Closed
Priority: Major
Resolution: Completed
Affects Version/s: Approved Backlog, Backlog, Release 1.2, Release 1.3
Fix Version/s: Release 1.3
Component/s: None
Labels:
None
Environment:
Affects Clojure from 1.2.0 to 1.3.0-alpha4

Approval:
Ok

Description

The code below defines a macro wrapper around defrecord. Using it causes a VerifyError:

(defmacro mac1 [name properties] 
  (let [key-info (keyword (first (filter #(meta %) properties)))] 
    (prn key-info) 
    `(defrecord ~name ~properties))) 

(mac1 One [^:key one, two])

Once this happens, the running Clojure process is oddly damaged. Changing the macro to a working version (see below) will not make the sample work with the tagged symbol, almost as if the symbol
'one (below) became corrupt. You either need to start a new REPL, or try to invoke the macro with a different tagged symbol.

The following code does work (note the forced conversion to a string):

(defmacro mac2 [name properties] 
  (let [key-info (keyword (str (first (filter #(meta %) properties))))] 
    (prn key-info) 
    `(defrecord ~name ~properties))) 

(mac2 Two [^:key three, four])

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Rich Hickey added a comment - 17/Dec/10 8:47 AM

Stu, can you please verify?

Show

Rich Hickey added a comment - 17/Dec/10 8:47 AM Stu, can you please verify?

Hide

Permalink

Stuart Halloway added a comment - 17/Dec/10 1:53 PM

Very confusing. Reproduced everything in the report. Moreover, leaving out the call to keyword is enough to avoid the problem. The following variant works fine:

(defmacro mac4 [name properties] 
  (let [key-info (first (filter #(meta %) properties))] 
    (prn key-info) 
    `(defrecord ~name ~properties)))

Show

Stuart Halloway added a comment - 17/Dec/10 1:53 PM Very confusing. Reproduced everything in the report. Moreover, leaving out the call to keyword is enough to avoid the problem. The following variant works fine:

(defmacro mac4 [name properties] 
  (let [key-info (first (filter #(meta %) properties))] 
    (prn key-info) 
    `(defrecord ~name ~properties)))

Hide

Permalink

Constantine Vetoshev added a comment - 18/Dec/10 1:02 PM

Thanks for the fix! Works great.

Show

Constantine Vetoshev added a comment - 18/Dec/10 1:02 PM Thanks for the fix! Works great.

People

Assignee:

Rich Hickey

Reporter:

Constantine Vetoshev

Vote (0)

Watch (1)

Dates

Created:

16/Dec/10 8:54 AM

Updated:

01/Mar/13 12:47 PM

Resolved:

17/Dec/10 4:19 PM