Clojure

GC Issue 68: every? returns nil instead of false

Details

  • Type: Defect Defect
  • Status: Closed Closed
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: Release 1.1
  • Component/s: None
  • Labels:
    None
  • Approval:
    Ok

Description

Reported by pedro.dhb, Feb 07, 2009


What (small set of) steps will reproduce the problem?

(every? #{\space} "dam") #=> nil


What is the expected output? What do you see instead?
The expected output is false according to the API docs for every?. Currently nil is returned.

What version are you using?
SVN revision 1252

Was this discussed on the group? If so, please provide a link to the discussion:
It was mentioned on the IRC but not in the groups.

Please provide any additional information below.
_END _INFO



Comment 1 by slash2314, Feb 24, 2009

If need needs to return false in this case, I propose the following patch.

Activity

Hide
Assembla Importer added a comment -

oranenj said: [file:bjODraw3Kr3O2PeJe5afGb]: on comment 1

Show
Assembla Importer added a comment - oranenj said: [file:bjODraw3Kr3O2PeJe5afGb]: on comment 1
Hide
Assembla Importer added a comment -

richhickey said: Updating tickets (#8, #19, #30, #31, #126, #17, #42, #47, #50, #61, #64, #69, #71, #77, #79, #84, #87, #89, #96, #99, #103, #107, #112, #113, #114, #115, #118, #119, #121, #122, #124)

Show
Assembla Importer added a comment - richhickey said: Updating tickets (#8, #19, #30, #31, #126, #17, #42, #47, #50, #61, #64, #69, #71, #77, #79, #84, #87, #89, #96, #99, #103, #107, #112, #113, #114, #115, #118, #119, #121, #122, #124)
Hide
Assembla Importer added a comment -

richhickey said: No CA from original submitter - fresh patch welcome

Show
Assembla Importer added a comment - richhickey said: No CA from original submitter - fresh patch welcome
Hide
Assembla Importer added a comment -

richhickey said: Updating tickets (#42, #71)

Show
Assembla Importer added a comment - richhickey said: Updating tickets (#42, #71)
Hide
Assembla Importer added a comment -
Show
Assembla Importer added a comment - oranenj said: [file:drpB3kxNar3PzkeJe5afGb]
Hide
Assembla Importer added a comment -
Show
Assembla Importer added a comment - oranenj said: [file:bZMX5WxNqr3P5SeJe5afGb]
Hide
Assembla Importer added a comment -

oranenj said: Sorry for the "double post".
This new patch compiles fine for me and passes all the tests in contrib, so it doesn't look like anything depends on every? returning nil.

Show
Assembla Importer added a comment - oranenj said: Sorry for the "double post". This new patch compiles fine for me and passes all the tests in contrib, so it doesn't look like anything depends on every? returning nil.
Hide
Assembla Importer added a comment -

oranenj said: (In [[r:b03e19aa341fea01c1279a74f4184f6538d0f72e]]) core: make every? return false instead of nil

Refs #71

Signed-off-by: Chouser <chouser@n01se.net>

Branch: master

Show
Assembla Importer added a comment - oranenj said: (In [[r:b03e19aa341fea01c1279a74f4184f6538d0f72e]]) core: make every? return false instead of nil Refs #71 Signed-off-by: Chouser <chouser@n01se.net> Branch: master
Hide
Assembla Importer added a comment -

chouser@n01se.net said: Created ticket #133 to track this fix against Clojure 1.0. That allows this ticket to be closed.

Dup'ing a ticket like this is a bit of work, but if we like the results it can probably be automated pretty easily.

Show
Assembla Importer added a comment - chouser@n01se.net said: Created ticket #133 to track this fix against Clojure 1.0. That allows this ticket to be closed. Dup'ing a ticket like this is a bit of work, but if we like the results it can probably be automated pretty easily.

People

  • Assignee:
    Unassigned
    Reporter:
    Anonymous
Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: