Clojure

Remove *earmuff* == dynamic support

Details

  • Type: Enhancement Enhancement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: Release 1.3
  • Component/s: None
  • Labels:
    None
  • Patch:
    Code
  • Approval:
    Ok

Description

As a compatibility bridge, when dynamic var support was first added, *earmuffed* vars were automagically considered dynamic. Users were promised this bridge would be removed before release. Let's get this change in so people can start dealing with it.

Activity

Hide
Alexander Taggart added a comment -

Remove the warning message as well?

Show
Alexander Taggart added a comment - Remove the warning message as well?
Hide
Rich Hickey added a comment - - edited

The warning message should be changed to say:

Warning: *x* not declared dynamic and thus is not dynamically rebindable, but its name suggests otherwise. Please either indicate ^:dynamic *x* or change the name.

Show
Rich Hickey added a comment - - edited The warning message should be changed to say: Warning: *x* not declared dynamic and thus is not dynamically rebindable, but its name suggests otherwise. Please either indicate ^:dynamic *x* or change the name.
Hide
Alexander Taggart added a comment -

752.patch removes inferring ^:dynamic from earmuffed var; updates warning message.

Show
Alexander Taggart added a comment - 752.patch removes inferring ^:dynamic from earmuffed var; updates warning message.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: