Clojure

Implicit casting behaviour of into-array differs from <primitive>-array

Details

  • Type: Defect Defect
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Completed
  • Affects Version/s: Release 1.3
  • Fix Version/s: Release 1.6
  • Component/s: None
  • Labels:
    None
  • Patch:
    Code and Test
  • Approval:
    Ok

Description

The behavior of byte-array and short-array is inconsistent with the other <type>-array functions and with the into-array function when invoked with types other than byte or short. All of the other cases upcast to Number, then extract the primitive value, allowing this operation to succeed (assuming the value is in range). byte-array and short-array throw a ClassCastException.

Example:

base64v3a=> (into-array Byte/TYPE [1 2 3 4])  ;; int to byte ok
#<byte[] [B@5ee04fd>
base64v3a=> (byte-array [1 2 3 4])  ;; int to byte NOT ok!! 
ClassCastException java.lang.Long cannot be cast to java.lang.Byte
  clojure.lang.Numbers.byte_array (Numbers.java:1418)
base64v3a=> (long-array [1 2 3 4])  ;; int to long ok
#<long[] [J@3f9f4d1d>

into-array (via RT.seqToTypedArray) and the other <type>-array functions all upcast to Number via Numbers.<type>_array), then obtain the proper primitive value. Numbers.byte-array and Numbers.short-array do casts directly to Byte and Short (yielding the ClassCastException).

The attached patch makes the Byte and Short cases match the other types and the into-array behavior. Tests are included. The submitter is a contributor.

Patch: clj766-2.patch

Screened by: Alex Miller

Activity

Alexander Taggart made changes -
Field Original Value New Value
Attachment clj766.patch [ 10174 ]
Alexander Taggart made changes -
Attachment clj766.patch [ 10174 ]
Karsten Schmidt made changes -
Attachment byte-short-array-ctors.diff [ 11887 ]
Karsten Schmidt made changes -
Attachment byte-short-array-ctors.diff [ 11887 ]
Karsten Schmidt made changes -
Attachment byte-short-array-ctors.diff [ 11890 ]
Stuart Halloway made changes -
Approval Triaged [ 10120 ]
Rich Hickey made changes -
Approval Triaged [ 10120 ] Vetted [ 10003 ]
Rich Hickey made changes -
Fix Version/s Release 1.6 [ 10157 ]
Andy Fingerhut made changes -
Patch Code and Test [ 10002 ]
Alex Miller made changes -
Assignee Alex Miller [ alexmiller ]
Alex Miller made changes -
Description Example:

{noformat}
base64v3a=> (into-array Byte/TYPE [1 2 3 4])
#<byte[] [B@5ee04fd>
base64v3a=> (byte-array [1 2 3 4])
ClassCastException java.lang.Long cannot be cast to java.lang.Byte
  clojure.lang.Numbers.byte_array (Numbers.java:1418)
{noformat}

While into-array (via RT.seqToTypedArray) casts each element prior to inserting into the array, byte-array (via Numbers.byte_array) does an unchecked cast to Byte.

Current patch: byte-short-array-ctors.diff

The behavior of {{byte-array}} and {{short-array}} is inconsistent with the other {{<type>-array}} functions and with the {{into-array}} function when invoked with types other than byte or short. All of the other cases upcast to Number, then extract the primitive value, allowing this operation to succeed (assuming the value is in range). {{byte-array}} and {{short-array}} throw a ClassCastException.

Example:

{noformat}
base64v3a=> (into-array Byte/TYPE [1 2 3 4]) ;; int to byte ok
#<byte[] [B@5ee04fd>
base64v3a=> (byte-array [1 2 3 4]) ;; int to byte NOT ok!!
ClassCastException java.lang.Long cannot be cast to java.lang.Byte
  clojure.lang.Numbers.byte_array (Numbers.java:1418)
base64v3a=> (long-array [1 2 3 4]) ;; long to int ok
#<long[] [J@3f9f4d1d>
{noformat}

{{into-array}} (via {{RT.seqToTypedArray}}) and the other {{<type>-array}} functions all upcast to Number (via Numbers.<type>_array}}), then obtain the proper primitive value. {{Numbers.byte-array}} and {{Numbers.short-array}} do casts directly to Byte and Short (yielding the ClassCastException).

The attached patch makes the Byte and Short cases match the other types and the {{into-array}} behavior. Tests are included. The submitter is a contributor.
Alex Miller made changes -
Approval Vetted [ 10003 ] Incomplete [ 10006 ]
Assignee Alex Miller [ alexmiller ] Karsten Schmidt [ toxi ]
Alex Miller made changes -
Description Current patch: byte-short-array-ctors.diff

The behavior of {{byte-array}} and {{short-array}} is inconsistent with the other {{<type>-array}} functions and with the {{into-array}} function when invoked with types other than byte or short. All of the other cases upcast to Number, then extract the primitive value, allowing this operation to succeed (assuming the value is in range). {{byte-array}} and {{short-array}} throw a ClassCastException.

Example:

{noformat}
base64v3a=> (into-array Byte/TYPE [1 2 3 4]) ;; int to byte ok
#<byte[] [B@5ee04fd>
base64v3a=> (byte-array [1 2 3 4]) ;; int to byte NOT ok!!
ClassCastException java.lang.Long cannot be cast to java.lang.Byte
  clojure.lang.Numbers.byte_array (Numbers.java:1418)
base64v3a=> (long-array [1 2 3 4]) ;; long to int ok
#<long[] [J@3f9f4d1d>
{noformat}

{{into-array}} (via {{RT.seqToTypedArray}}) and the other {{<type>-array}} functions all upcast to Number (via Numbers.<type>_array}}), then obtain the proper primitive value. {{Numbers.byte-array}} and {{Numbers.short-array}} do casts directly to Byte and Short (yielding the ClassCastException).

The attached patch makes the Byte and Short cases match the other types and the {{into-array}} behavior. Tests are included. The submitter is a contributor.
Current patch: byte-short-array-ctors.diff

The behavior of {{byte-array}} and {{short-array}} is inconsistent with the other {{<type>-array}} functions and with the {{into-array}} function when invoked with types other than byte or short. All of the other cases upcast to Number, then extract the primitive value, allowing this operation to succeed (assuming the value is in range). {{byte-array}} and {{short-array}} throw a ClassCastException.

Example:

{noformat}
base64v3a=> (into-array Byte/TYPE [1 2 3 4]) ;; int to byte ok
#<byte[] [B@5ee04fd>
base64v3a=> (byte-array [1 2 3 4]) ;; int to byte NOT ok!!
ClassCastException java.lang.Long cannot be cast to java.lang.Byte
  clojure.lang.Numbers.byte_array (Numbers.java:1418)
base64v3a=> (long-array [1 2 3 4]) ;; int to long ok
#<long[] [J@3f9f4d1d>
{noformat}

{{into-array}} (via {{RT.seqToTypedArray}}) and the other {{<type>-array}} functions all upcast to Number (via Numbers.<type>_array}}), then obtain the proper primitive value. {{Numbers.byte-array}} and {{Numbers.short-array}} do casts directly to Byte and Short (yielding the ClassCastException).

The attached patch makes the Byte and Short cases match the other types and the {{into-array}} behavior. Tests are included. The submitter is a contributor.
Alex Miller made changes -
Waiting On toxi
Alex Miller made changes -
Description Current patch: byte-short-array-ctors.diff

The behavior of {{byte-array}} and {{short-array}} is inconsistent with the other {{<type>-array}} functions and with the {{into-array}} function when invoked with types other than byte or short. All of the other cases upcast to Number, then extract the primitive value, allowing this operation to succeed (assuming the value is in range). {{byte-array}} and {{short-array}} throw a ClassCastException.

Example:

{noformat}
base64v3a=> (into-array Byte/TYPE [1 2 3 4]) ;; int to byte ok
#<byte[] [B@5ee04fd>
base64v3a=> (byte-array [1 2 3 4]) ;; int to byte NOT ok!!
ClassCastException java.lang.Long cannot be cast to java.lang.Byte
  clojure.lang.Numbers.byte_array (Numbers.java:1418)
base64v3a=> (long-array [1 2 3 4]) ;; int to long ok
#<long[] [J@3f9f4d1d>
{noformat}

{{into-array}} (via {{RT.seqToTypedArray}}) and the other {{<type>-array}} functions all upcast to Number (via Numbers.<type>_array}}), then obtain the proper primitive value. {{Numbers.byte-array}} and {{Numbers.short-array}} do casts directly to Byte and Short (yielding the ClassCastException).

The attached patch makes the Byte and Short cases match the other types and the {{into-array}} behavior. Tests are included. The submitter is a contributor.
Current patch: byte-short-array-ctors.diff

The behavior of {{byte-array}} and {{short-array}} is inconsistent with the other {{<type>-array}} functions and with the {{into-array}} function when invoked with types other than byte or short. All of the other cases upcast to Number, then extract the primitive value, allowing this operation to succeed (assuming the value is in range). {{byte-array}} and {{short-array}} throw a ClassCastException.

Example:

{noformat}
base64v3a=> (into-array Byte/TYPE [1 2 3 4]) ;; int to byte ok
#<byte[] [B@5ee04fd>
base64v3a=> (byte-array [1 2 3 4]) ;; int to byte NOT ok!!
ClassCastException java.lang.Long cannot be cast to java.lang.Byte
  clojure.lang.Numbers.byte_array (Numbers.java:1418)
base64v3a=> (long-array [1 2 3 4]) ;; int to long ok
#<long[] [J@3f9f4d1d>
{noformat}

{{into-array}} (via {{RT.seqToTypedArray}}) and the other {{<type>-array}} functions all upcast to Number via {{Numbers.<type>_array}}), then obtain the proper primitive value. {{Numbers.byte-array}} and {{Numbers.short-array}} do casts directly to Byte and Short (yielding the ClassCastException).

The attached patch makes the Byte and Short cases match the other types and the {{into-array}} behavior. Tests are included. The submitter is a contributor.
Alex Miller made changes -
Approval Incomplete [ 10006 ] Screened [ 10004 ]
Description Current patch: byte-short-array-ctors.diff

The behavior of {{byte-array}} and {{short-array}} is inconsistent with the other {{<type>-array}} functions and with the {{into-array}} function when invoked with types other than byte or short. All of the other cases upcast to Number, then extract the primitive value, allowing this operation to succeed (assuming the value is in range). {{byte-array}} and {{short-array}} throw a ClassCastException.

Example:

{noformat}
base64v3a=> (into-array Byte/TYPE [1 2 3 4]) ;; int to byte ok
#<byte[] [B@5ee04fd>
base64v3a=> (byte-array [1 2 3 4]) ;; int to byte NOT ok!!
ClassCastException java.lang.Long cannot be cast to java.lang.Byte
  clojure.lang.Numbers.byte_array (Numbers.java:1418)
base64v3a=> (long-array [1 2 3 4]) ;; int to long ok
#<long[] [J@3f9f4d1d>
{noformat}

{{into-array}} (via {{RT.seqToTypedArray}}) and the other {{<type>-array}} functions all upcast to Number via {{Numbers.<type>_array}}), then obtain the proper primitive value. {{Numbers.byte-array}} and {{Numbers.short-array}} do casts directly to Byte and Short (yielding the ClassCastException).

The attached patch makes the Byte and Short cases match the other types and the {{into-array}} behavior. Tests are included. The submitter is a contributor.
The behavior of {{byte-array}} and {{short-array}} is inconsistent with the other {{<type>-array}} functions and with the {{into-array}} function when invoked with types other than byte or short. All of the other cases upcast to Number, then extract the primitive value, allowing this operation to succeed (assuming the value is in range). {{byte-array}} and {{short-array}} throw a ClassCastException.

Example:

{noformat}
base64v3a=> (into-array Byte/TYPE [1 2 3 4]) ;; int to byte ok
#<byte[] [B@5ee04fd>
base64v3a=> (byte-array [1 2 3 4]) ;; int to byte NOT ok!!
ClassCastException java.lang.Long cannot be cast to java.lang.Byte
  clojure.lang.Numbers.byte_array (Numbers.java:1418)
base64v3a=> (long-array [1 2 3 4]) ;; int to long ok
#<long[] [J@3f9f4d1d>
{noformat}

{{into-array}} (via {{RT.seqToTypedArray}}) and the other {{<type>-array}} functions all upcast to Number via {{Numbers.<type>_array}}), then obtain the proper primitive value. {{Numbers.byte-array}} and {{Numbers.short-array}} do casts directly to Byte and Short (yielding the ClassCastException).

The attached patch makes the Byte and Short cases match the other types and the {{into-array}} behavior. Tests are included. The submitter is a contributor.

*Patch:* clj766-2.patch

*Screened by:* Alex Miller
Attachment clj766-2.patch [ 12214 ]
Alex Miller made changes -
Assignee Karsten Schmidt [ toxi ]
Rich Hickey made changes -
Approval Screened [ 10004 ] Ok [ 10007 ]
Stuart Halloway made changes -
Resolution Completed [ 1 ]
Status Open [ 1 ] Closed [ 6 ]

People

Vote (3)
Watch (6)

Dates

  • Created:
    Updated:
    Resolved: