Clojure

Move unchecked-prim casts to clojure.unchecked

Details

  • Type: Enhancement Enhancement
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: Backlog
  • Fix Version/s: Backlog
  • Component/s: None
  • Labels:
  • Patch:
    Code and Test
  • Approval:
    Vetted

Description

Per Rich's comment in CLJ-767:

Moving unchecked coercions into unchecked ns is ok

  1. clj-771-move-unchecked-casts-patch-v5.txt
    13/Feb/13 12:50 AM
    12 kB
    Andy Fingerhut
  2. move-unchecked-casts.patch
    29/Apr/11 3:41 PM
    12 kB
    Alexander Taggart
  3. move-unchecked-casts-v2.patch
    19/May/12 9:36 AM
    12 kB
    John Szakmeister

Activity

Alexander Taggart made changes -
Field Original Value New Value
Attachment 771.patch [ 10179 ]
Alexander Taggart made changes -
Attachment 771.patch [ 10179 ]
Hide
Alexander Taggart added a comment -

Requires that patch on CLJ-782 be applied first.

Show
Alexander Taggart added a comment - Requires that patch on CLJ-782 be applied first.
Alexander Taggart made changes -
Attachment move-unchecked-casts.patch [ 10213 ]
Alexander Taggart made changes -
Assignee Alexander Taggart [ ataggart ]
Priority Major [ 3 ] Minor [ 4 ]
Approval Test
Waiting On stu
Patch Code and Test
Alexander Taggart made changes -
Status Open [ 1 ] In Progress [ 3 ]
Alexander Taggart made changes -
Status In Progress [ 3 ] Open [ 1 ]
Alexander Taggart made changes -
Description See Rich's comment in CLJ-767. Per Rich's comment in CLJ-767:

bq. Moving unchecked coercions into unchecked ns is ok
Hide
Stuart Sierra added a comment -

Applies on master as of commit 66a88de9408e93cf2b0d73382e662624a54c6c86

Show
Stuart Sierra added a comment - Applies on master as of commit 66a88de9408e93cf2b0d73382e662624a54c6c86
Stuart Sierra made changes -
Fix Version/s Backlog [ 10035 ]
Affects Version/s Backlog [ 10035 ]
Approval Test Screened
Waiting On stu richhickey
Hide
Rich Hickey added a comment -

still considering when to incorporate this

Show
Rich Hickey added a comment - still considering when to incorporate this
Rich Hickey made changes -
Approval Screened [ 10004 ] Incomplete [ 10006 ]
Hide
John Szakmeister added a comment -

v2 of the patch applies to master as of commit eccde24c7fb63679f00c64b3c70c03956f0ce2c3

Show
John Szakmeister added a comment - v2 of the patch applies to master as of commit eccde24c7fb63679f00c64b3c70c03956f0ce2c3
John Szakmeister made changes -
Attachment move-unchecked-casts-v2.patch [ 11235 ]
Hide
Andy Fingerhut added a comment -

Patch clj-771-move-unchecked-casts-patch-v3.txt dated Sep 6 2012 is the same as Alexander Taggart's patch move-unchecked-casts.patch except that it has been updated to apply cleanly to latest Clojure master.

Show
Andy Fingerhut added a comment - Patch clj-771-move-unchecked-casts-patch-v3.txt dated Sep 6 2012 is the same as Alexander Taggart's patch move-unchecked-casts.patch except that it has been updated to apply cleanly to latest Clojure master.
Andy Fingerhut made changes -
Attachment clj-771-move-unchecked-casts-patch-v3.txt [ 11482 ]
Hide
Andy Fingerhut added a comment -

Patch clj-771-move-unchecked-casts-patch-v4.txt dated Oct 20 2012 is the same as Alexander Taggart's patch move-unchecked-casts.patch except that it has been updated to apply cleanly to latest Clojure master.

Show
Andy Fingerhut added a comment - Patch clj-771-move-unchecked-casts-patch-v4.txt dated Oct 20 2012 is the same as Alexander Taggart's patch move-unchecked-casts.patch except that it has been updated to apply cleanly to latest Clojure master.
Andy Fingerhut made changes -
Attachment clj-771-move-unchecked-casts-patch-v4.txt [ 11589 ]
Andy Fingerhut made changes -
Attachment clj-771-move-unchecked-casts-patch-v3.txt [ 11482 ]
Hide
Andy Fingerhut added a comment -

The patch clj-771-move-unchecked-casts-patch-v4.txt applies cleanly to latest master and passes all tests. Rich marked this ticket as Incomplete on Dec 9 2011 with the comment "still considering when to incorporate this" above. Is it reasonable to change it back to Vetted or Screened so it can be considered again, perhaps after Release 1.5 is made?

Show
Andy Fingerhut added a comment - The patch clj-771-move-unchecked-casts-patch-v4.txt applies cleanly to latest master and passes all tests. Rich marked this ticket as Incomplete on Dec 9 2011 with the comment "still considering when to incorporate this" above. Is it reasonable to change it back to Vetted or Screened so it can be considered again, perhaps after Release 1.5 is made?
Hide
Andy Fingerhut added a comment -

Patch clj-771-move-unchecked-casts-patch-v5.txt dated Feb 12 2013 is the same as Alexander Taggart's patch move-unchecked-casts.patch except that it has been updated to apply cleanly to latest Clojure master.

Show
Andy Fingerhut added a comment - Patch clj-771-move-unchecked-casts-patch-v5.txt dated Feb 12 2013 is the same as Alexander Taggart's patch move-unchecked-casts.patch except that it has been updated to apply cleanly to latest Clojure master.
Andy Fingerhut made changes -
Andy Fingerhut made changes -
Attachment clj-771-move-unchecked-casts-patch-v4.txt [ 11589 ]
Alex Miller made changes -
Approval Incomplete [ 10006 ] Vetted [ 10003 ]
Alex Miller made changes -
Labels math

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated: