[#CLJ-787] transient blows up when passed a vector created by subvec - Clojure JIRA

Details

Type: Defect
Status: Open
Priority: Minor
Resolution: Unresolved
Affects Version/s: Backlog
Fix Version/s: Release 1.6
Component/s: None
Labels:
None

Approval:
Vetted

Description

Subvectors created with subvec from a PersistentVector cannot be made transient:

user=> (transient (subvec [1 2 3 4] 2))
ClassCastException clojure.lang.APersistentVector$SubVector cannot be cast to clojure.lang.IEditableCollection  clojure.core/transient (core.clj:2864)

Activity

Hide

Permalink

Stuart Sierra added a comment - 31/May/11 9:28 AM

Confirmed. APersistentVector$SubVector does not implement IEditableCollection.

The current implementation of TransientVector depends on implementation details of PersistentVector, so it is not a trivial fix. The simplest fix might be to implement IEditableCollection.asTransient in SubVector by creating a new PersistentVector, but I do not know the performance implications.

Show

Stuart Sierra added a comment - 31/May/11 9:28 AM Confirmed. APersistentVector$SubVector does not implement IEditableCollection. The current implementation of TransientVector depends on implementation details of PersistentVector, so it is not a trivial fix. The simplest fix might be to implement IEditableCollection.asTransient in SubVector by creating a new PersistentVector, but I do not know the performance implications.

People

Assignee:

Unassigned

Reporter:

Alexander Redington

Vote (0)

Watch (2)

Dates

Created:

03/May/11 7:23 AM

Updated:

12/Apr/13 9:42 AM