Clojure

Refactor method resolution code out of Compiler and into Reflector

Details

  • Type: Enhancement Enhancement
  • Status: Open Open
  • Priority: Major Major
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

Issues:

  1. Code for obtaining method/constructor instances is duplicated across the Compiler
  2. Code for resolving a preferred overloaded method lives in the Compiler

By consolidating the duplicated code, moving the reflection-related parts into Reflector, and providing a straightforward API, it should be easier to read and understand the method resolution process. Further, improvements to (e.g., CLJ-445) the mechanism for reflecting on class members can largely be isolated from the Compiler. And the few points of coordination (e.g., Compiler emitting same arg and return types as Reflector does when invoking) can be clearly identified and documented.

Activity

Hide
Andy Fingerhut added a comment -

I don't know if this is helpful or not, but this updated version of Alexander's patch applies cleanly to latest Clojure head as of Feb 20, 2012. It compiles, but does not pass ant test.

Show
Andy Fingerhut added a comment - I don't know if this is helpful or not, but this updated version of Alexander's patch applies cleanly to latest Clojure head as of Feb 20, 2012. It compiles, but does not pass ant test.
Hide
Alexander Taggart added a comment -

Yeah, year-old patches tend to do that.

Show
Alexander Taggart added a comment - Yeah, year-old patches tend to do that.
Hide
Stuart Sierra added a comment -

Patch does not apply as of commit f5bcf64.

Show
Stuart Sierra added a comment - Patch does not apply as of commit f5bcf64.

People

Vote (0)
Watch (3)

Dates

  • Created:
    Updated: