[#CLJ-879] Allow :require to support a :refer clause - Clojure JIRA

Details

Type: Enhancement
Status: Closed
Priority: Minor
Resolution: Completed
Affects Version/s: None
Fix Version/s: None
Component/s: None
Labels:
- patch,
- test

Patch:
Code and Test
Approval:
Ok

Description

There's been discussion previously about the complexity of the ns
macro. In particular the fact that :use causes all vars to be referred
by default is widely seen as unfortunate, and the distinction between
use and require is a source of conceptual overhead for people new to
the language.

We can't change the fact that :use refers everything by default
without breaking lots of existing code. But it would be possible to
enhance :require to support referring specified vars, leaving us free
to deprecate or otherwise discourage the use of :use.

Clojure-dev thread discussing this: http://groups.google.com/group/clojure-dev/browse_thread/thread/91b708ddb909affd

More Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

0001-Allow-require-to-take-a-refer-option.patch

25/Nov/11 2:52 PM

3 kB

Phil Hagelberg

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Phil Hagelberg added a comment - 25/Nov/11 2:52 PM

Patch containing implementation, test, and documentation.

Show

Phil Hagelberg added a comment - 25/Nov/11 2:52 PM Patch containing implementation, test, and documentation.

Hide

Permalink

Phil Hagelberg added a comment - 06/Jan/12 2:21 PM

Any chance we could get some discussion going on this?

Show

Phil Hagelberg added a comment - 06/Jan/12 2:21 PM Any chance we could get some discussion going on this?

Hide

Permalink

Devin Torres added a comment - 14/Jan/12 1:12 AM

I'd love to see this discussed.

Show

Devin Torres added a comment - 14/Jan/12 1:12 AM I'd love to see this discussed.

Hide

Permalink

Phil Hagelberg added a comment - 27/Jan/12 4:42 PM

So... how about it? Thoughts?

Show

Phil Hagelberg added a comment - 27/Jan/12 4:42 PM So... how about it? Thoughts?

Hide

Permalink

Kevin Downey added a comment - 17/Feb/12 11:30 AM

patch still applies cleanly to master, tests pass

there is a warning when you run the tests though:

[java] Testing clojure.test-clojure.keywords
[java]
[java] Testing clojure.test-clojure.load
[java] WARNING: with-bindings already refers to: #'clojure.core/with-bindings in namespace: clojure.test-clojure.require-scratch, being replaced by: #'clojure.main/with-bindings
[java]
[java] Testing clojure.test-clojure.logic
[java]
[java] Testing clojure.test-clojure.macros

Show

Kevin Downey added a comment - 17/Feb/12 11:30 AM patch still applies cleanly to master, tests pass there is a warning when you run the tests though: [java] Testing clojure.test-clojure.keywords [java] [java] Testing clojure.test-clojure.load [java] WARNING: with-bindings already refers to: #'clojure.core/with-bindings in namespace: clojure.test-clojure.require-scratch, being replaced by: #'clojure.main/with-bindings [java] [java] Testing clojure.test-clojure.logic [java] [java] Testing clojure.test-clojure.macros

Hide

Permalink

Stuart Sierra added a comment - 17/Feb/12 1:36 PM

Vetted. Patch is good, although it needs docstring updates in 'require'

Show

Stuart Sierra added a comment - 17/Feb/12 1:36 PM Vetted. Patch is good, although it needs docstring updates in 'require'

Hide

Permalink

Stuart Sierra added a comment - 17/Feb/12 1:55 PM

Not Vetted. I can't remember what the names mean. Ready for Rich. That's "Test" right?

Show

Stuart Sierra added a comment - 17/Feb/12 1:55 PM Not Vetted. I can't remember what the names mean. Ready for Rich. That's "Test" right?

Hide

Permalink

Stuart Sierra added a comment - 17/Feb/12 1:59 PM - edited

My mistake. The docstring is included in 'require', but not in 'refer', which also changed. But the public API of 'refer' did not change. So this patch is good.

Show

Stuart Sierra added a comment - 17/Feb/12 1:59 PM - edited My mistake. The docstring is included in 'require', but not in 'refer', which also changed. But the public API of 'refer' did not change. So this patch is good.

Hide

Permalink

Stuart Sierra added a comment - 17/Feb/12 2:08 PM

Not "Test." Screened. The patch is Screened. I hate this.

Show

Stuart Sierra added a comment - 17/Feb/12 2:08 PM Not "Test." Screened. The patch is Screened. I hate this.

Hide

Permalink

Stuart Sierra added a comment - 17/Feb/12 2:18 PM

Patch applied.

Show

Stuart Sierra added a comment - 17/Feb/12 2:18 PM Patch applied.

People

Assignee:

Phil Hagelberg

Reporter:

Phil Hagelberg

Vote (9)

Watch (7)

Dates

Created:

17/Nov/11 4:08 PM

Updated:

17/Feb/12 2:18 PM

Resolved:

17/Feb/12 2:18 PM