Clojure

• Type: Defect
• Status: Closed
• Priority: Major
• Resolution: Completed
• Affects Version/s: Release 1.3
• Fix Version/s: Release 1.4
• Component/s: None
• Labels:

  • patch,
• Environment:

  all

See comments in fix:

(defmethod do-copy [InputStream Writer] [#^InputStream input #^Writer output opts]
;; WRONG! if the buffer boundry falls in the middle of a multibyte character, we will get garbled results.
#_
(let [#^"[B" buffer (make-array Byte/TYPE (buffer-size opts))]
(loop []
(let [size (.read input buffer)]
(when (pos? size)
(let [chars (.toCharArray (String. buffer 0 size (encoding opts)))]
(do (.write output chars)
(recur)))))))
;; here we decode the characters before stuffing them into the buffer
(let [#^"[C" buffer (make-array Character/TYPE (buffer-size opts))
in (InputStreamReader. input (encoding opts))]
(loop []
(let [size (.read in buffer 0 (alength buffer))]
(if (pos? size)
(do (.write output buffer 0 size)
(recur)))))))

1. 

   clj-886.diff

   05/Dec/11 11:23 AM

   2 kB

   Jeff Palmucci

2. 

   CLJ-886-fix2.patch

   09/Feb/12 8:13 PM

   7 kB

   Andy Fingerhut

• Assignee:

  Unassigned

  Reporter:

  Jeff Palmucci

  Waiting On:

  Rich Hickey

• Created:

  28/Nov/11 4:24 PM

  Updated:

  23/Mar/12 8:40 AM

  Resolved:

  23/Mar/12 8:40 AM