[#CLJ-892] sort changes its argument, if a Java array - Clojure JIRA

Details

Type: Enhancement
Status: Closed
Priority: Minor
Resolution: Completed
Affects Version/s: Release 1.3, Release 1.4
Fix Version/s: Reviewed Backlog, Release 1.5
Component/s: None
Labels:
None
Environment:
java version "1.6.0_22"
OpenJDK Runtime Environment (IcedTea6 1.10.4) (6b22-1.10.4-0ubuntu1~11.04.1)
(clojure-version)
"1.4.0-alpha2"

Patch:
Code
Approval:
Ok

Description

user> (let [a (to-array [32 11])]
(prn (seq a))
(sort a)
(prn (seq a)))
(32 11)
(11 32)
nil

Where the second line printed ought to be the same as the first.

More Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

clj-892-clarify-sort-sort-by-doc-strings-patch1.txt

26/Mar/12 5:32 PM

1 kB

Andy Fingerhut

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Stuart Halloway added a comment - 09/Dec/11 9:37 AM

This is an enhancement request, since the docs for sort make no promise one way or the other.

For performance, I prefer the current behavior, so another possibility is a clarifying doc string.

Show

Stuart Halloway added a comment - 09/Dec/11 9:37 AM This is an enhancement request, since the docs for sort make no promise one way or the other. For performance, I prefer the current behavior, so another possibility is a clarifying doc string.

Stuart Halloway made changes - 09/Dec/11 9:37 AM

Field	Original Value	New Value
Priority	Major [ 3 ]	Minor [ 4 ]
Fix Version/s		Reviewed Backlog [ 10053 ]
Issue Type	Defect [ 1 ]	Enhancement [ 4 ]

Hide

Permalink

Andy Fingerhut added a comment - 26/Mar/12 5:32 PM

clj-892-clarify-sort-sort-by-doc-strings-patch1.txt of Mar 26, 2012 applies cleanly to latest master on that date. Only doc string changes, to make it clear that by sort and sort-by will modify Java arrays given as arguments.

Show

Andy Fingerhut added a comment - 26/Mar/12 5:32 PM clj-892-clarify-sort-sort-by-doc-strings-patch1.txt of Mar 26, 2012 applies cleanly to latest master on that date. Only doc string changes, to make it clear that by sort and sort-by will modify Java arrays given as arguments.

Andy Fingerhut made changes - 26/Mar/12 5:32 PM

Attachment

clj-892-clarify-sort-sort-by-doc-strings-patch1.txt [ 11012 ]

Andy Fingerhut made changes - 26/Mar/12 5:32 PM

Patch

Code [ 10001 ]

Rich Hickey made changes - 13/Apr/12 8:06 AM

Approval		Ok [ 10007 ]
Fix Version/s		Release 1.5 [ 10150 ]

Stuart Halloway made changes - 18/May/12 12:35 PM

Resolution		Completed [ 1 ]
Status	Open [ 1 ]	Closed [ 6 ]

People

Assignee:

Unassigned

Reporter:

Stephen Compall

Vote (0)

Watch (1)

Dates

Created:

08/Dec/11 7:14 PM

Updated:

18/May/12 12:35 PM

Resolved:

18/May/12 12:35 PM