Clojure

GC Issue 3: Re-enable detection of circular loads

Details

  • Type: Enhancement Enhancement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: Release 1.3
  • Component/s: None
  • Labels:
    None
  • Patch:
    Code and Test
  • Approval:
    Ok

Description

Reported by richhickey, Dec 17, 2008
Was made a no-op for AOT/gen-class - need to distinguish cases

Comment 1 by richhickey, Dec 17, 2008
(No comment was entered for this change.)
Owner: ---
Comment 2 by richhickey, Dec 18, 2008
(No comment was entered for this change.)
Labels: Priority-High
Comment 3 by scgilardi, May 12, 2009
Rich, do you have an example of the problem with AOT/gen-class that motivated
disabling detection of circular loads? With that in hand, I'd like to take a look at
fixing this.
Comment 4 by richhickey, May 13, 2009
You should just try it out. I'm not sure if it is just something I encountered on my
way to the final mechanism (and now isn't needed). However, you should hold off right
at the moment, as I'm working on loading/classloader stuff.

Activity

Hide
Assembla Importer added a comment -

richhickey said: Updating tickets (#8, #19, #30, #31, #126, #17, #42, #47, #50, #61, #64, #69, #71, #77, #79, #84, #87, #89, #96, #99, #103, #107, #112, #113, #114, #115, #118, #119, #121, #122, #124)

Show
Assembla Importer added a comment - richhickey said: Updating tickets (#8, #19, #30, #31, #126, #17, #42, #47, #50, #61, #64, #69, #71, #77, #79, #84, #87, #89, #96, #99, #103, #107, #112, #113, #114, #115, #118, #119, #121, #122, #124)
Hide
Assembla Importer added a comment -

scgilardi said: I'm working on this now. I plan to have more info by 19 October.

Show
Assembla Importer added a comment - scgilardi said: I'm working on this now. I plan to have more info by 19 October.
Hide
Assembla Importer added a comment -

richhickey said: Updating tickets (#8, #42, #113, #2, #20, #94, #96, #104, #119, #124, #127, #149, #162)

Show
Assembla Importer added a comment - richhickey said: Updating tickets (#8, #42, #113, #2, #20, #94, #96, #104, #119, #124, #127, #149, #162)
Hide
Assembla Importer added a comment -

scgilardi said: [file:arZXq-2qKr3R8teJe5aVNr]: fixes tickets 8, 42, and 113

Show
Assembla Importer added a comment - scgilardi said: [file:arZXq-2qKr3R8teJe5aVNr]: fixes tickets 8, 42, and 113
Hide
Assembla Importer added a comment -

scgilardi said: please see my posting to the developer group

Show
Assembla Importer added a comment - scgilardi said: please see my posting to the developer group
Hide
Assembla Importer added a comment -

scgilardi said: [file:aUykkoZfSr35wNeJe5cbCb]: patch to detect/reject cyclic deps

Show
Assembla Importer added a comment - scgilardi said: [file:aUykkoZfSr35wNeJe5cbCb]: patch to detect/reject cyclic deps
Hide
Assembla Importer added a comment -

scgilardi said: fresh patch that detects and rejects cyclic dependencies. based on today's master. tests included.

Show
Assembla Importer added a comment - scgilardi said: fresh patch that detects and rejects cyclic dependencies. based on today's master. tests included.
Hide
Stephen C. Gilardi added a comment -

I provided a patch for this. Is there anything further I can or must do to to move it along?

Show
Stephen C. Gilardi added a comment - I provided a patch for this. Is there anything further I can or must do to to move it along?
Hide
Stuart Halloway added a comment -

Had to recreate the patch almost from scratch. Haven't seen this problem before--when the git merge failed, it wouldn't create any .rej files to work with.

Recreated patch is same as Steve's, except for a test configuration change to match current MASTER.

Show
Stuart Halloway added a comment - Had to recreate the patch almost from scratch. Haven't seen this problem before--when the git merge failed, it wouldn't create any .rej files to work with. Recreated patch is same as Steve's, except for a test configuration change to match current MASTER.
Stuart Halloway made changes -
Field Original Value New Value
Fix Version/s Release.Next [ 10038 ]
Fix Version/s Approved Backlog [ 10034 ]
Attachment 0008-cyclic-deps-resolved.patch [ 10081 ]
Reporter Stephen C. Gilardi [ scgilardi ]
Priority Minor [ 4 ]
Approval Test Screened
Patch Code and Test
Rich Hickey made changes -
Approval Screened Ok
Stuart Halloway made changes -
Status In Progress [ 3 ] Closed [ 6 ]
Resolution Completed [ 1 ]

People

Vote (2)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: