Clojure

• Type: Defect
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: Release 1.6
• Fix Version/s: Release 1.6
• Component/s: None
• Labels:

  None

clojure.string/triml and trimr use Character/isWhitespace to determine whether a character is whitespace, but trim uses some other definition of white space character. For example:

user=> (use 'clojure.string)
nil
user=> (def s " \u2002 foo")
#'user/s
user=> (trim s)
"? foo"
user=> (triml s)
"foo"

The attached patch changes trim to use Character/isWhitespace. I suppose other possibilities are to change triml and trimr to use trim's notion of whitespace, whatever that is, or to just leave these functions inconsistent with each other. It does seem that it would be a nice property that (trim s) is equal to (triml (trimr s)) for all strings.

The patch also changes triml to only call .length on s once.

1. 

   fix-trim-fns-different-whitespace-patch.txt

   21/Feb/12 1:29 PM

   3 kB

   Andy Fingerhut

• Assignee:

  Aaron Bedra

  Reporter:

  Andy Fingerhut

• Created:

  21/Feb/12 1:29 PM

  Updated:

  11/Apr/13 5:36 PM