[#CLJ-943] When load-lib fails, a namespace is still created - Clojure JIRA

Details

Type: Defect
Status: Closed
Priority: Major
Resolution: Completed
Affects Version/s: Release 1.3, Release 1.4
Fix Version/s: Release 1.5
Component/s: None
Labels:
None

Patch:
Code and Test
Approval:
Ok

Description

When requiring a namespace that doesn't compile, a namespace is still created. The attached patch removes the namespace on failure if the namespace wasn't already present on entry to load-lib. See the test case in the patch for repro instructions.

This is obviously a subset of having atomic loads. Would a step further in this direction, e.g. using a swapable state object within clojure.lang.Namespace be of interest?

More Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

0001-Remove-namespace-if-load-lib-fails-and-namespace-did.patch

01/Mar/12 7:30 PM

3 kB

Hugo Duncan

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Stuart Halloway added a comment - 08/Jun/12 3:17 PM

Why catch Exception, not Throwable?

Show

Stuart Halloway added a comment - 08/Jun/12 3:17 PM Why catch Exception, not Throwable?

Hide

Permalink

Stuart Halloway added a comment - 08/Jun/12 3:23 PM

This patch accomplishes its purpose, although (in the absence of fully atomic load) I would imagine it creates a race condition if one thread tried to load a broken namespace while another thread tried simply to create a namespace.

Marked screened anyway...

Show

Stuart Halloway added a comment - 08/Jun/12 3:23 PM This patch accomplishes its purpose, although (in the absence of fully atomic load) I would imagine it creates a race condition if one thread tried to load a broken namespace while another thread tried simply to create a namespace. Marked screened anyway...

People

Assignee:

Unassigned

Reporter:

Hugo Duncan

Vote (0)

Watch (0)

Dates

Created:

01/Mar/12 7:30 PM

Updated:

15/Jun/12 11:09 AM

Resolved:

15/Jun/12 11:09 AM