Clojure

It would be very useful to be able to annotate the constructors of classes created with gen-class

Details

  • Type: Enhancement Enhancement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: Release 1.5
  • Component/s: None
  • Labels:
    None
  • Patch:
    Code and Test
  • Approval:
    Ok

Description

gen-class currently provides a way to annotate methods, but not constructors.

when interoperating with java code that uses google juice heavily the ability to annotate constructors is required.

Activity

Kevin Downey made changes -
Field Original Value New Value
Status Open [ 1 ] In Progress [ 3 ]
Kevin Downey made changes -
Attachment CLJ-948.patch [ 10980 ]
Kevin Downey made changes -
Patch Code and Test [ 10002 ]
Kevin Downey made changes -
Assignee Kevin Downey [ hiredman ] Chouser [ chouser@n01se.net ]
Hide
Andy Fingerhut added a comment -

clj-948-annotate-gen-class-constructors-patch2.txt same as Kevin's CLJ-948.patch, but with slight update so it applies cleanly to latest master as of March 9, 2012. ant builds and tests with no errors or warnings. One author Kevin Downey has signed CA.

Show
Andy Fingerhut added a comment - clj-948-annotate-gen-class-constructors-patch2.txt same as Kevin's CLJ-948.patch, but with slight update so it applies cleanly to latest master as of March 9, 2012. ant builds and tests with no errors or warnings. One author Kevin Downey has signed CA.
Andy Fingerhut made changes -
Attachment clj-948-annotate-gen-class-constructors-patch2.txt [ 10988 ]
Hide
Andy Fingerhut added a comment -

clj-948-annotate-gen-class-constructors-patch3.txt on Mar 26, 2012 is no different from previous patches, except that it applies cleanly to latest master as of that date. One author Kevin Downey has signed a CA. Kevin, you don't need to thank me again. The last time gave me eye damage (only joking).

Show
Andy Fingerhut added a comment - clj-948-annotate-gen-class-constructors-patch3.txt on Mar 26, 2012 is no different from previous patches, except that it applies cleanly to latest master as of that date. One author Kevin Downey has signed a CA. Kevin, you don't need to thank me again. The last time gave me eye damage (only joking).
Andy Fingerhut made changes -
Andy Fingerhut made changes -
Attachment clj-948-annotate-gen-class-constructors-patch2.txt [ 10988 ]
Hide
Chouser added a comment -

Patch is small and is a nice improvement. Tests look good and pass.

Show
Chouser added a comment - Patch is small and is a nice improvement. Tests look good and pass.
Chouser made changes -
Approval Screened [ 10004 ]
Rich Hickey made changes -
Approval Screened [ 10004 ] Ok [ 10007 ]
Fix Version/s Release 1.5 [ 10150 ]
Stuart Halloway made changes -
Resolution Completed [ 1 ]
Status In Progress [ 3 ] Closed [ 6 ]

People

Vote (1)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: