Clojure

GC Issue 92: Check for key identity in collections

Details

  • Type: Enhancement Enhancement
  • Status: Closed Closed
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: Release 1.2
  • Component/s: None
  • Labels:
    None
  • Approval:
    Ok

Description

Reported by chouser, Mar 09, 2009

Describe the feature/change.

Clojure code routes key lookups through
clojure.lang.Util.equiv()/equals(), which do an identity check.

Using the collections from outside Clojure may to more expensive
comparisons even on identical objects, so each collection should also
do an identity check.

Was this discussed on the group? If so, please provide a link to the
discussion:

http://groups.google.com/group/clojure/msg/6a2e491fcf564a68

Activity

Hide
Assembla Importer added a comment -
Show
Assembla Importer added a comment - Converted from http://www.assembla.com/spaces/clojure/tickets/96 Attachments: 0001-Check-for-identity-before-equality-in-.equals-for-co.patch - https://www.assembla.com/spaces/clojure/documents/ch_3rOrUir36rbeJe5d-aX/download/ch_3rOrUir36rbeJe5d-aX
Hide
Assembla Importer added a comment -

richhickey said: Updating tickets (#8, #19, #30, #31, #126, #17, #42, #47, #50, #61, #64, #69, #71, #77, #79, #84, #87, #89, #96, #99, #103, #107, #112, #113, #114, #115, #118, #119, #121, #122, #124)

Show
Assembla Importer added a comment - richhickey said: Updating tickets (#8, #19, #30, #31, #126, #17, #42, #47, #50, #61, #64, #69, #71, #77, #79, #84, #87, #89, #96, #99, #103, #107, #112, #113, #114, #115, #118, #119, #121, #122, #124)
Hide
Assembla Importer added a comment -

richhickey said: Updating tickets (#8, #42, #113, #2, #20, #94, #96, #104, #119, #124, #127, #149, #162)

Show
Assembla Importer added a comment - richhickey said: Updating tickets (#8, #42, #113, #2, #20, #94, #96, #104, #119, #124, #127, #149, #162)
Hide
Assembla Importer added a comment -

richhickey said: Updating tickets (#94, #96, #104, #119, #163)

Show
Assembla Importer added a comment - richhickey said: Updating tickets (#94, #96, #104, #119, #163)
Hide
Assembla Importer added a comment -

cgrand said: [file:ch_3rOrUir36rbeJe5d-aX]: patch

Show
Assembla Importer added a comment - cgrand said: [file:ch_3rOrUir36rbeJe5d-aX]: patch
Hide
Assembla Importer added a comment -

cgrand said: Add identity check to .equals in gvec, ASeq, APersistentVector, APersistentSet and APersistentMap.

Show
Assembla Importer added a comment - cgrand said: Add identity check to .equals in gvec, ASeq, APersistentVector, APersistentSet and APersistentMap.
Hide
Assembla Importer added a comment -

cgrand said: (In [[r:ee9fc81dd2ef15d7ea3e17e7ec2370c5c09d633e]]) Check for identity before equality in .equals for collections, see #96

Signed-off-by: Stuart Halloway <stu@thinkrelevance.com>

Branch: master

Show
Assembla Importer added a comment - cgrand said: (In [[r:ee9fc81dd2ef15d7ea3e17e7ec2370c5c09d633e]]) Check for identity before equality in .equals for collections, see #96 Signed-off-by: Stuart Halloway <stu@thinkrelevance.com> Branch: master

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: