Clojure

Capture :column metadata (needed for ClojureScript source maps)

Details

  • Type: Enhancement Enhancement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: Release 1.5
  • Component/s: None
  • Labels:
  • Patch:
    Code and Test
  • Approval:
    Ok

Description

I've begun working on implementing SourceMaps for ClojureScript. For an overview of SourceMaps, see: http://www.html5rocks.com/en/tutorials/developertools/sourcemaps/ For discussion of the feature in ClojureScript, see: https://groups.google.com/d/topic/clojure-dev/zgmXO2iM1JQ/discussion

In order to produce accurate source maps, I need column information in addition to line information from the Clojure reader.

I've made the necessary enhancement to LispReader, etc. but have some cleanup and testing left to do. I'd also like a sanity check from the core team before attaching a formal patch. You can find my work in progress here: https://github.com/brandonbloom/clojure/compare/columns

  1. CLJ-960-tests.diff
    19/Oct/12 11:45 AM
    2 kB
    Chas Emerick
  2. columns-1.patch
    14/Apr/12 6:43 PM
    40 kB
    Brandon Bloom
  3. columns-1-v2.patch
    27/Jul/12 5:32 AM
    40 kB
    John Szakmeister

Activity

Rich Hickey made changes -
Field Original Value New Value
Labels patch,
Brandon Bloom made changes -
Attachment columns-1.patch [ 11050 ]
Brandon Bloom made changes -
Labels patch patch,
John Szakmeister made changes -
Attachment columns-1-v2.patch [ 11401 ]
Rich Hickey made changes -
Approval Vetted [ 10003 ]
Fix Version/s Release 1.5 [ 10150 ]
Labels patch patch, patch
Chas Emerick made changes -
Attachment CLJ-960-tests.diff [ 11579 ]
Stuart Halloway made changes -
Approval Vetted [ 10003 ] Screened [ 10004 ]
Rich Hickey made changes -
Approval Screened [ 10004 ] Ok [ 10007 ]
Stuart Halloway made changes -
Resolution Completed [ 1 ]
Status Open [ 1 ] Closed [ 6 ]

People

Vote (2)
Watch (4)

Dates

  • Created:
    Updated:
    Resolved: