Clojure

• Type: Defect
• Status: Closed
• Priority: Trivial
• Resolution: Completed
• Affects Version/s: Release 1.3
• Fix Version/s: None
• Component/s: None
• Labels:

  None

When a Var has an in-thread binding and I use with-redefs to temporarily alter its root binding, the value restored to the root binding after with-redefs is finished will not be the original root value, but the thread-local one. The problem is using deref instead of something like clojure.lang.Var's .getRawRoot to backup the original root values in with-derefs-fn.

I have never used with-redefs and it is very unlikely that one would use it while the Vars in question are thread-bound. However, when reading the function's definition in Joy of Clojure and later in core.clj, I did not believe this behaviour was intended.

1. 

   0001-with-redefs-saves-root-binding-instead-of-thread-loc.patch

   10/Jul/12 6:47 PM

   1 kB

   Gary Fredericks

2. 

   with_redefs_bug.clj

   28/Mar/12 11:05 AM

   0.1 kB

   Jiří Maršík

• Assignee:

  Rich Hickey

  Reporter:

  Jiří Maršík

• Created:

  28/Mar/12 11:05 AM

  Updated:

  20/Jul/12 4:44 PM

  Resolved:

  20/Jul/12 4:44 PM