[#CLJ-966] Add support for marker protocols - Clojure JIRA

Details

Type: Enhancement
Status: Closed
Priority: Minor
Resolution: Completed
Affects Version/s: None
Fix Version/s: Release 1.5
Component/s: None
Labels:
None

Patch:
Code and Test
Approval:
Ok

Description

The attached patch adds support to marker protocols, for example

(defprotocol Sequential
"marker protocol indicating a sequential type")

More Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

CLJ-966-additional-marker-tests-APPLY-AFTER.diff

15/Aug/12 2:40 PM

2 kB

Fogus
marker-protocols.diff

05/Apr/12 7:16 AM

5 kB

Nicola Mometto

Activity

Ascending order - Click to sort in descending order

Hide

Permalink

Jonas Enlund added a comment - 07/Apr/12 1:20 PM

Marker protocols are supported and used in ClojureScript.

Show

Jonas Enlund added a comment - 07/Apr/12 1:20 PM Marker protocols are supported and used in ClojureScript.

Hide

Permalink

Kevin Downey added a comment - 15/Aug/12 2:23 PM

what are the uses for marker protocols? I know there are marker interfaces in java, but is it a pattern we want to carry forward?

Show

Kevin Downey added a comment - 15/Aug/12 2:23 PM what are the uses for marker protocols? I know there are marker interfaces in java, but is it a pattern we want to carry forward?

Hide

Permalink

Fogus added a comment - 15/Aug/12 2:40 PM

Nice and simple. Tested with:

(defprotocol P (hi [_]))
(defprotocol M)
(deftype T [a] M P (hi [_] "hi there"))
(satisfies? P (T. 1))
(satisfies? M (T. 1))
(hi (T. 1))
(defprotocol M2 "marker for 2")
(extend-type T M2)
(satisfies? M2 (T. 1))

Similar tests are included in the additional patch file as test cases. This additional patch file should be applied after the feature's main patch file.

Show

Fogus added a comment - 15/Aug/12 2:40 PM Nice and simple. Tested with:

(defprotocol P (hi [_]))
(defprotocol M)
(deftype T [a] M P (hi [_] "hi there"))
(satisfies? P (T. 1))
(satisfies? M (T. 1))
(hi (T. 1))
(defprotocol M2 "marker for 2")
(extend-type T M2)
(satisfies? M2 (T. 1))

Similar tests are included in the additional patch file as test cases. This additional patch file should be applied after the feature's main patch file.

People

Assignee:

Unassigned

Reporter:

Nicola Mometto

Vote (2)

Watch (1)

Dates

Created:

05/Apr/12 7:16 AM

Updated:

18/Aug/12 7:50 AM

Resolved:

18/Aug/12 7:50 AM