Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

proxy-super does not restore original binding if call throws exception

Description

The code for proxy-call-with-super internally used by proxy-super does not handle exceptions from the call method:

As a result the following sequence behaves unexpectedly:

Patch: clj-983-2.patch

Approach: Use a try-finally block around the invocation to perform the after invocation action regardless of exceptions.

Screened by: Stuart Sierra

Environment

None

Attachments

2

Activity

Show:

Stuart Sierra January 10, 2014 at 10:22 PM

Screened OK.

Alex Miller January 6, 2014 at 9:06 PM

Added new clean patch for screening consideration.

Alex Miller January 6, 2014 at 7:07 PM

Incomplete - needs clean patch.

Alex Miller January 3, 2014 at 6:33 PM

Marked vetted in 1.6 per Rich.

Alex Miller December 26, 2013 at 1:24 PM

Patch provider does not have a signed CA so can't be accepted as is.

Completed

Details

Assignee

Reporter

Labels

Approval

Ok

Patch

Code and Test

Priority

Affects versions

Fix versions

Created May 5, 2012 at 9:36 AM
Updated January 31, 2014 at 6:19 PM
Resolved January 31, 2014 at 6:19 PM