self-host: doseq does not behave as expected

Description

When a doseq appears in non-terminal position inside a do block, it "iterates" repeatedly over the first element only.

This only affects bootstrapped clojurescript, but can be supported with a vanilla cljs.js setup and the last example below.

Correctly prints 1 and then 2:

(do :before (doseq [x [1 2]] (println x)))

Correctly does not iterate, and returns :after

(do (doseq [x []] (println x)) :after)

Incorrectly prints 1 ad infinitum

(do (doseq [x [1 2]] (println x)) :after)

Example code including bootstrapping:

(def source "(do (doseq [e [1 2]] (println e)) 3)")

(cljs/eval-str
  (cljs/empty-state)
  source
  source
  {:eval       cljs/js-eval
   :source-map false
   :verbose    true}
  prn)

For convenience a repo to run this example is here:

https://github.com/crisptrutski/do-doseq-bootstrapped

Environment

None

Attachments

1400.patch

12 Aug, 2015

infinite_loop2.patch

07 Aug, 2015

infinite_loop.patch

07 Aug, 2015

Activity

Mike Fikes

August 29, 2015 at 8:54 PM

Confirmed that fix works downstream in Planck.

David Nolen

August 29, 2015 at 5:40 PM

fixed https://github.com/clojure/clojurescript/commit/3636a80c9b683cdc1190bd60910bf805e6ab22c0

Jeff Palentine

August 29, 2015 at 4:33 PM

Mind if I close this as superceded by http://dev.clojure.org/jira/browse/CLJS-1435?

The latter makes a better test case (failure terminates...)

David Nolen

August 29, 2015 at 4:00 PM

Details

Assignee

Jeff Palentine

Reporter

Jeff Palentine

Approval

Vetted

Priority

Major

Created August 7, 2015 at 10:41 AM

Updated August 29, 2015 at 8:54 PM

Resolved August 29, 2015 at 8:54 PM