ClojureScript

using keywords as fns is slow

Details

  • Type: Defect Defect
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

Modifying native prototypes is useful but very slow in v8 & jsc. For common patterns like keywords as fns - this is a big performance hit. The compiler should perhaps emit a shared keyword wrapper which implements IFn.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
David Nolen added a comment -

Rich gave me a good suggestion - optimize at the call site - fast path is property lookup.

Show
David Nolen added a comment - Rich gave me a good suggestion - optimize at the call site - fast path is property lookup.
Hide
Permalink
David Nolen added a comment - - edited

fixed, http://github.com/clojure/clojurescript/commit/17ed473db0bc1759965667f975d89d9c01dda34b

Doesn't handle the higher order case, but we can make a separate ticket for that.

Show
David Nolen added a comment - - edited fixed, http://github.com/clojure/clojurescript/commit/17ed473db0bc1759965667f975d89d9c01dda34b Doesn't handle the higher order case, but we can make a separate ticket for that.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4#649-r158309) | Report a problem
Powered by a free Atlassian JIRA open source license for Clojure. Try JIRA - bug tracking software for your team.