:parallel-build causes invalid truth check in cljs.reader/read-number

Description

When compiling a large project with arallel-build true I see intermitted failures in a test that parses "0" with cljs.reader/read-string.

Inspecting the difference in generated code between a successful build and failed build, I see the following difference in cljs.reader/read-number:

Environment

None

Activity

David Nolen

February 19, 2016 at 8:03 PM

fixed https://github.com/clojure/clojurescript/commit/c59e957f6230c07e7a228070dd8eb393d5b8ce40

David Nolen

February 15, 2016 at 10:04 PM

This is a good catch, we should be binding cljs.analyzer/unchecked-if before analyzing or compiling a namespace to avoid other threads seeing a state change. It should also just get a simple false root binding and then we can avoid reader conditionals.

Resize work item view side panel

Completed

Details

Assignee

David Nolen

Reporter

Andrew Childs

Affects versions

1.7.228

Priority

Major

Created February 15, 2016 at 1:11 AM

Updated February 19, 2016 at 8:03 PM

Resolved February 19, 2016 at 8:03 PM