ClojureScript

Suggest removing UNIX shell executable permissions from bin/cljsc.bat

Details

Description

Bash completion shows `bin/cljsc.bat` as an executable on UNIX systems
making it very easy to accidentally execute it. However, since
Windows command scripts do not work with UNIX shells, it is not
advisable to allow executable permissions to Windows batch scripts
as accidentally executing them may cause undefined behavior on such
systems.

I strongly suggest stripping UNIX shell executable permissions from
`bin/cljsc.bat`.

Thank you.

Cheers,
Yesudeep.

Activity

Hide
Yesudeep Mangalapilly added a comment -

The issue also affects:

bin/cljsc.bat
script/repljs.bat
script/repl.bat

Show
Yesudeep Mangalapilly added a comment - The issue also affects: bin/cljsc.bat script/repljs.bat script/repl.bat
Hide
Craig Andera added a comment -

I've verified (on both Ubuntu Linux and Windows 7) that stripping the x bit from those files has the desired effect.

The patch is almost too trivial to bother with listing here, but here it is regardless:

diff --git a/bin/cljsc.bat b/bin/cljsc.bat
old mode 100755
new mode 100644
diff --git a/script/repl.bat b/script/repl.bat
old mode 100755
new mode 100644
diff --git a/script/repljs.bat b/script/repljs.bat
old mode 100755
new mode 100644
Show
Craig Andera added a comment - I've verified (on both Ubuntu Linux and Windows 7) that stripping the x bit from those files has the desired effect. The patch is almost too trivial to bother with listing here, but here it is regardless:
diff --git a/bin/cljsc.bat b/bin/cljsc.bat
old mode 100755
new mode 100644
diff --git a/script/repl.bat b/script/repl.bat
old mode 100755
new mode 100644
diff --git a/script/repljs.bat b/script/repljs.bat
old mode 100755
new mode 100644

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: