Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Resolve ns aliases in syntax quote

Description

This test (cljs/syntax_quote_test.cljs) fails:

The first assertion passes (since f240826034), but the remaining assertions fail: test is not resolved to cljs.test, so e.g. `test/foo is just 'test/foo.

Of course, the analogous clojure/syntax_quote_test.clj passes:

Attached patch resolve-ns-aliases-in-syntax-quote.patch contains the failing test and an attempted fix.

Environment

None

Attachments

4

Activity

Show:

David Nolen April 23, 2016 at 9:18 PM

fixed https://github.com/clojure/clojurescript/commit/1e794f0a9d6c03b12644f00cd8aa4f8a3e86ab83. Not sure why the patch wasn't applying for me before.

Mike Fikes April 23, 2016 at 8:41 PM

Yeah, I can confirm what Tom's seeing. Here's my alternate verification:

After this, script/test, script/test-self-host, and script/test-self-parity all pass as well.

Tom Jack April 23, 2016 at 8:28 PM

Hmm, Mike's latest patch CLJS-1612.patch seems to apply to master for me.

Thanks, Mike, by the way, for the patch and explanation!

David Nolen April 23, 2016 at 7:59 PM

The patch no longer applies to master, can we rebase?

Mike Fikes April 17, 2016 at 4:24 PM

CLJS-1612.patch includes Tom Jack's original change plus additional revisions for bootstrap.

Completed

Details

Assignee

Reporter

Patch

Code and Test

Priority

Created March 31, 2016 at 6:35 PM
Updated April 23, 2016 at 9:18 PM
Resolved April 23, 2016 at 9:18 PM