ClojureScript

cljs.core/str behavior not consistent with clojure

Details

  • Type: Defect Defect
  • Status: Resolved Resolved
  • Priority: Trivial Trivial
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
  • Environment:
    This is the behavior on rhino repl, haven't tested on browser

Description

When running the cljs.core/str function with symbols or keywords the output is not the same as in clojure

ClojureScript:cljs.user> (str "hello" :world)
"hello?'world"

The same happens with symbols, it seems the characters used internally for figuring out if a string is a keyword or symbol are not being escaped correctly on the cljs.core/str function.

Attachments

  1. Text File
    CLJS-162_1.patch
    16/Mar/12 11:55 PM
    4 kB
    Roman Gonzalez
  2. Text File
    CLJS-162_2.patch
    19/Mar/12 5:45 PM
    3 kB
    Roman Gonzalez
  3. Text File
    CLJS-162.patch
    15/Mar/12 9:18 PM
    0.8 kB
    Roman Gonzalez

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Roman Gonzalez added a comment -

Added check of symbols and keywords on the private cljs.core/str* function

Show
Roman Gonzalez added a comment - Added check of symbols and keywords on the private cljs.core/str* function
Roman Gonzalez made changes -
Field Original Value New Value
Attachment CLJS-162.patch [ 10993 ]
Hide
Permalink
David Nolen added a comment -

The patch looks good but some tests fail now. Can you address that? Thanks!

Show
David Nolen added a comment - The patch looks good but some tests fail now. Can you address that? Thanks!
Hide
Permalink
Roman Gonzalez added a comment -

Thanks for checking this out David, I didn't read the developer wiki (my bad), I added a few tests and added a new small function that will allow both str* and str to behave correctly, cheers.

Note: Use CLJS-162_1.patch

Show
Roman Gonzalez added a comment - Thanks for checking this out David, I didn't read the developer wiki (my bad), I added a few tests and added a new small function that will allow both str* and str to behave correctly, cheers. Note: Use CLJS-162_1.patch
Roman Gonzalez made changes -
Attachment CLJS-162_1.patch [ 10996 ]
Hide
Permalink
Roman Gonzalez added a comment -

New patch which just replicates the StringBuffer code from `str*` into the `str` implementation.

Show
Roman Gonzalez added a comment - New patch which just replicates the StringBuffer code from `str*` into the `str` implementation.
Roman Gonzalez made changes -
Attachment CLJS-162_2.patch [ 10998 ]
David Nolen made changes -
Resolution Completed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4#649-r158309) | Report a problem
Powered by a free Atlassian JIRA open source license for Clojure. Try JIRA - bug tracking software for your team.