ClojureScript

Mark some symbols in core macros ns as private

Details

  • Type: Enhancement Enhancement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Patch:
    Code

Description

There are some symbols in the core macros namespace that are not meant for external consumption. Some of these are marked private and some aren't. This ticket asks that the others be marked private as well.

An example of one symbol marked private is defcurried.
An example of one symbol not marked private is caching-hash.

  1. CLJS-1636.patch
    27/Apr/16 8:21 AM
    7 kB
    Mike Fikes
  2. CLJS-1636-2.patch
    31/Jul/16 1:33 PM
    7 kB
    Mike Fikes
  3. CLJS-1636-3.patch
    12/Feb/17 1:33 PM
    7 kB
    Mike Fikes

Activity

Hide
Mike Fikes added a comment -

In CLJS-1636.patch, I checked and it appears nothing in the compiler codebase is explicitly using these symbols outside of the cljs.core namespace. But, it is still worth scanning through these to check if they make sense. For example js-debugger and js-comment are a couple that might actually be meant for public use, but it is difficult to tell.

Show
Mike Fikes added a comment - In CLJS-1636.patch, I checked and it appears nothing in the compiler codebase is explicitly using these symbols outside of the cljs.core namespace. But, it is still worth scanning through these to check if they make sense. For example js-debugger and js-comment are a couple that might actually be meant for public use, but it is difficult to tell.
Hide
Mike Fikes added a comment -

Note, that in #cljs-dev slack, there appears to be interest in caching-hash being public.

(I don't mind revising the patch to suit whatever is needed. At the same time, I'm certainly not in a position to take decisions on what is public API or not.)

Show
Mike Fikes added a comment - Note, that in #cljs-dev slack, there appears to be interest in caching-hash being public. (I don't mind revising the patch to suit whatever is needed. At the same time, I'm certainly not in a position to take decisions on what is public API or not.)
Hide
Mike Fikes added a comment -

Note, that in #cljs-dev slack, there appears to be interest in caching-hash being public.

(I don't mind revising the patch to suit whatever is needed. At the same time, I'm certainly not in a position to take decisions on what is public API or not.)

Show
Mike Fikes added a comment - Note, that in #cljs-dev slack, there appears to be interest in caching-hash being public. (I don't mind revising the patch to suit whatever is needed. At the same time, I'm certainly not in a position to take decisions on what is public API or not.)
Hide
Mike Fikes added a comment -

Patch no longer applies. Attaching updated patch.

Show
Mike Fikes added a comment - Patch no longer applies. Attaching updated patch.
Hide
Mike Fikes added a comment -

Previous patch no longer applies; attaching re-baselined patch.

Show
Mike Fikes added a comment - Previous patch no longer applies; attaching re-baselined patch.

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: