Empty iterator for some hash maps with a nil key

Description

Two specific examples:

cljs.user=> (.hasNext (-iterator {:a 1 :b 2 :c 3 :d 4 :e 5 :f 6 :g 7 :h 8 nil 9}))
false
cljs.user=> (.hasNext (-iterator (hash-map nil 1))))
false

This can affect "user-level" code as follows:

cljs.user=> (sequence (map identity) {:a 1 :b 2 :c 3 :d 4 :e 5 :f 6 :g 7 :h 8 nil 9})
()
cljs.user=> (sequence (map identity) (hash-map nil 1))
()

None

CLJS-1765__1.patch

19 Sep, 2016

CLJS-1765.patch

15 Sep, 2016

CLJS-1765__2.patch

28 Aug, 2016

David Nolen

September 19, 2016 at 2:29 PM

Thomas Mulvaney

September 19, 2016 at 2:27 AM

Newest patch has been rebased and tests were split out into the namespace I proposed in previous comment.

Thomas Mulvaney

September 17, 2016 at 2:47 AM

I would be happy to put the tests in a new namespace. Does `src/test/cljs/cljs/hash_map_test.cljs` sound sensible?

David Nolen

September 16, 2016 at 7:30 PM

This ticket needs a rebase again. We should probably consider breaking up our core tests into individual namespaces.

Thomas Mulvaney

September 15, 2016 at 12:06 AM

Most recent patch is rebased.

Resize work item view side panel

Completed

Unassigned

Mike Fikes

Code and Test

Major

Created August 27, 2016 at 4:33 PM

Updated September 19, 2016 at 2:29 PM

Resolved September 19, 2016 at 2:29 PM