Self-host: allow namespaces to require their own macros

Description

Currently a namespace can only require its own macros in JVM ClojureScript (called macro-loop in this post).

Because there's no reader conditional distinction between JVM and Bootstrapped ClojureScript, requiring a namespace that requires its own macros in self-host will result in the following error:

Could not require foo.core in file /Users/anmonteiro/Desktop/foo/src/foo/core.cljc
Maximum call stack size exceeded.

Below is an example that can be used to reproduce the issue:

;; foo/core.cljc
(ns foo.core
  #?(:cljs (:require-macros [foo.core])))

(defmacro a-macro [& args]
  `(println ~@args))

This ticket proposes the following solution: when loading a macros namespace in self-hosted ClojureScript, patch its `require-macros` and `use-macros` entries to remove itself, if present.

Environment

None

Attachments

CLJS-1782.patch

27 Sep, 2016

Activity

David Nolen

September 30, 2016 at 6:02 PM

fixed https://github.com/clojure/clojurescript/commit/04751f337620279b0228856e4d224ae3d41abe72

António Monteiro

September 27, 2016 at 2:05 PM

Replaced the patch with a new one rebased on current master.

António Monteiro

September 20, 2016 at 3:09 AM

Attached patch with proposed fix.

Resize work item view side panel

Completed

Details

Assignee

David Nolen

Reporter

António Monteiro

Patch

Code

Fix versions

1.9.293

Priority

Major

Created September 20, 2016 at 2:23 AM

Updated September 30, 2016 at 6:02 PM

Resolved September 30, 2016 at 6:02 PM