cljs.test: Index out of bounds for stack element w/o line/column

Description

The cljs.test/js-line-and-column function does not properly handle stack elements that have no line and column information encoded in them. In particular, if you pass in something like "eval@[native code]" (which can be part of a stack from JavaScriptCore), you will get an index out of bounds exception.

Environment

None

Attachments

CLJS-1915.patch

28 Jan, 2017

Activity

Jinseop Kim

September 25, 2017 at 9:54 AM

https://dev.clojure.org/jira/browse/CLJS-2352

Jinseop Kim

September 24, 2017 at 9:12 AM

I got error as follow: "SyntaxError: illegal character[Learn More] test.js:246:90".
I think you should change 'NaN' to 'js/NaN'.

— test.js
246: return new cljs.core.PersistentVector(null, 2, 5, cljs.core.PersistentVector.EMPTY_NODE, [##NaN,##NaN], null);

David Nolen

January 28, 2017 at 5:11 PM

fixed https://github.com/clojure/clojurescript/commit/2f8a1529955acc943ac8082ab5848b2cba54bc4d

Resize work item view side panel

Completed

Details

Assignee

David Nolen

Reporter

Mike Fikes

Patch

Code and Test

Priority

Minor

Created January 28, 2017 at 4:59 PM

Updated September 25, 2017 at 9:54 AM

Resolved September 25, 2017 at 9:54 AM