ClojureScript

Minor additions to clojure.browser.dom

Details

  • Type: Enhancement Enhancement
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Patch:
    Code

Description

These two patches add clojure.browser.dom/remove-node and some missing docstrings to clojure.browser.dom.

What else can be done in this namespace? I don't want to break things, but I think some functions (log, click) don't really belong there.

Activity

Hide
Edward Tsech added a comment -

As I can see clojure.browser.dom isn't used in clojure.browser.repl. Is it there only for samples?

Show
Edward Tsech added a comment - As I can see clojure.browser.dom isn't used in clojure.browser.repl. Is it there only for samples?
Hide
Moritz Ulrich added a comment -

You might be right. It's still a very useful piece of code and makes DOM manipulation much more "clojure-y". I think it should be kept and improved.

Show
Moritz Ulrich added a comment - You might be right. It's still a very useful piece of code and makes DOM manipulation much more "clojure-y". I think it should be kept and improved.
Hide
David Nolen added a comment -

It's not my impression that clojure.browser.dom is meant to be a library for general consumption (though I could be wrong). I think it's there to support browser REPL and the samples.

Show
David Nolen added a comment - It's not my impression that clojure.browser.dom is meant to be a library for general consumption (though I could be wrong). I think it's there to support browser REPL and the samples.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated: