ClojureScript

Use protocol mask test in protocol fns

Details

  • Type: Enhancement Enhancement
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

This is a performance win on many browsers.

http://jsperf.com/direct-vs-chain/8

Activity

Michał Marczyk made changes -
Field Original Value New Value
Assignee Michał Marczyk [ michalmarczyk ]
Hide
Michał Marczyk added a comment -

See CLJS-247 for comments relevant to this patch.

Show
Michał Marczyk added a comment - See CLJS-247 for comments relevant to this patch.
Michał Marczyk made changes -
Hide
David Nolen added a comment - - edited

Not seeing much of a perf benefit from this, though Michal reports differently. More investigation is needed.

Show
David Nolen added a comment - - edited Not seeing much of a perf benefit from this, though Michal reports differently. More investigation is needed.
Hide
David Nolen added a comment -

patch no longer applies. I wonder if I see bad behavior because I was testing with node or it was prior to the fixes around avoiding deoptimization.

Show
David Nolen added a comment - patch no longer applies. I wonder if I see bad behavior because I was testing with node or it was prior to the fixes around avoiding deoptimization.
Hide
Michał Marczyk added a comment -

I'll bring it up to date with the recent changes, thanks for the prod!

Show
Michał Marczyk added a comment - I'll bring it up to date with the recent changes, thanks for the prod!
David Nolen made changes -
Priority Major [ 3 ] Minor [ 4 ]
Issue Type Defect [ 1 ] Enhancement [ 4 ]

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated: