ClojureScript

Add clojure.core/shuffle implementation

Details

  • Type: Enhancement Enhancement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Patch:
    Code and Test

Description

I added a simple implementation of clojure.core/shuffle, which uses goog.array's Fisher-Yates for its implementation. Included in the patch is a test to make sure it works.

  1. 0001-Add-clojure.core-shuffle-and-a-test.patch
    20/May/12 4:24 PM
    2 kB
    Evan Mezeske
  2. shuffle.patch
    17/May/12 6:45 PM
    1 kB
    Evan Mezeske
  3. shuffle.v2.patch
    17/May/12 7:11 PM
    1 kB
    Evan Mezeske

Activity

Hide
David Nolen added a comment -

Why don't you return a vector like Clojure does?

Show
David Nolen added a comment - Why don't you return a vector like Clojure does?
Hide
Evan Mezeske added a comment -

Return a vector like Clojure.

Show
Evan Mezeske added a comment - Return a vector like Clojure.
Hide
David Nolen added a comment -

The patch is not correctly formatted with attribution.

Show
David Nolen added a comment - The patch is not correctly formatted with attribution.
Hide
Evan Mezeske added a comment -

Use git format-patch instead of git diff, to hopefully provide the right patch format.

Show
Evan Mezeske added a comment - Use git format-patch instead of git diff, to hopefully provide the right patch format.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: