ClojureScript

Inline instance?

Details

  • Type: Enhancement Enhancement
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
  • Patch:
    Code

Description

See discussion on http://dev.clojure.org/jira/browse/CLJS-300

This is a low priority patch for inlining instanceof checks. I don't know if it has any significant performance improvement, but the patch was sort of a side effect of my work on CLJS-300, so I figured I'd bundle it up and share it here in case someone wants to test it's perf impact and apply if it is a win.

  1. CLJS-301-v002.patch
    22/Dec/12 4:33 PM
    2 kB
    Brandon Bloom
  2. inline-instanceof.patch
    05/Jun/12 12:58 AM
    3 kB
    Brandon Bloom

Activity

David Nolen made changes -
Field Original Value New Value
Priority Minor [ 4 ] Trivial [ 5 ]
Hide
David Nolen added a comment -

This will probably result in a minor performance boost, but it is nice to get another jsSTAR out of core.cljs. If you update the patch to work on master, I will apply it.

Show
David Nolen added a comment - This will probably result in a minor performance boost, but it is nice to get another jsSTAR out of core.cljs. If you update the patch to work on master, I will apply it.
Brandon Bloom made changes -
Attachment CLJS-301-v002.patch [ 11775 ]
Hide
Brandon Bloom added a comment -

Was fixed awhile ago by another patch

Show
Brandon Bloom added a comment - Was fixed awhile ago by another patch
Brandon Bloom made changes -
Resolution Completed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
David Nolen made changes -
Status Resolved [ 5 ] Closed [ 6 ]

People

Vote (0)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved: