ClojureScript

fns should hash by identity

Details

  • Type: Enhancement Enhancement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Approval:
    Ok

Description

currently hit -hash missing when you try to make them e.g. map keys.

I have committed a fix (https://github.com/clojure/clojurescript/commit/22a64ff17b343b6c61039fcb66fd9acf34d98522) which uses goog.getUid for function objects. While I don't like goog.getUid for arbitrary objects, I think it is a good fit for functions, which need to hash by identity, but only occasionally.

Activity

Hide
Rich Hickey added a comment -

ok by me

Show
Rich Hickey added a comment - ok by me

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: