ClojureScript

Remove TODO comments in clojure.browser.dom

Details

  • Type: Task Task
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Declined
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

Remove line https://github.com/clojure/clojurescript/blob/master/src/cljs/clojure/browser/dom.cljs#L151
and https://github.com/clojure/clojurescript/blob/master/src/cljs/clojure/browser/dom.cljs#L152

Because we can just use Google Closure class library directly:
(ns boom.core
(:require [clojure.browser.dom :as dom]
[goog.dom.classes :as cl]
[goog.dom :as gdom]))

(def el (gdom/getElement "some-element"))

;; Add class
(cl/add el "boom")
;; Remove class
(cl/remove el "boom")
;; Toggle class
(cl/toggle el "boom")
...

Activity

Hide
David Nolen added a comment -

Not even important enough to be considered trivial

Show
David Nolen added a comment - Not even important enough to be considered trivial

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: