ClojureScript

Add docstring from def and ns definitions to @namespaces metadata map, and make reflect functions make use of that

Details

  • Type: Enhancement Enhancement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Environment:
    clojure/clojurescript "0.0-1450"
  • Patch:
    Code

Description

The docstrings were parsed from the definitions-forms for def and ns, but not added to the @namespaces metadata map.
There is no :doc entry used in the ns' metadata in the @namespaces.
No ns's :doc info is communicated to the browser in the reflect functions with reflect/doc.
Patch-file is attached with code-changes that add the :doc info for ns and def to the @namespaces, and enhances the reflect functions to communicate that info to the browser in the reflect/doc call.

Activity

Hide
David Nolen added a comment -

Excellent, fixed http://github.com/clojure/clojurescript/commit/bef56a74f2eeecabfe0c0a28d89b455dce576ea3

Please at the ticket # to the commit message though, thanks!

Show
David Nolen added a comment - Excellent, fixed http://github.com/clojure/clojurescript/commit/bef56a74f2eeecabfe0c0a28d89b455dce576ea3 Please at the ticket # to the commit message though, thanks!
Hide
Frank Siebenlist added a comment -

This patch should apply to master version on Mon, 15 Oct 2012 22:03:19 -0700 (4defcbcf19112b9be6a4a27b5d8855552bf94948)

Show
Frank Siebenlist added a comment - This patch should apply to master version on Mon, 15 Oct 2012 22:03:19 -0700 (4defcbcf19112b9be6a4a27b5d8855552bf94948)
Hide
David Nolen added a comment -

This patch no longer applies, mind updating it?

Show
David Nolen added a comment - This patch no longer applies, mind updating it?

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: