ClojureScript

reduce-kv doesn't work for all data structures

Details

  • Type: Defect Defect
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

Right now reduce-kv is not implemented for ObjMap and broken for ArrayMap.

Activity

Hide
Herwig Hochleitner added a comment -

Patch contains fixes and tests

Show
Herwig Hochleitner added a comment - Patch contains fixes and tests
Hide
Herwig Hochleitner added a comment -

Please note, that this patch was based on my local version for CLJS-401
I hope this won't produce any merge errors in the test code, since the two test cases are next to each other. I'll produce a new patch, if nessecary.

Show
Herwig Hochleitner added a comment - Please note, that this patch was based on my local version for CLJS-401 I hope this won't produce any merge errors in the test code, since the two test cases are next to each other. I'll produce a new patch, if nessecary.
Hide
David Nolen added a comment -

Patch no longer applies can you make a new one? Thanks!

Show
David Nolen added a comment - Patch no longer applies can you make a new one? Thanks!
Hide
Herwig Hochleitner added a comment -

Patch 0002 replaces 0001
np

Show
Herwig Hochleitner added a comment - Patch 0002 replaces 0001 np
Hide
David Nolen added a comment -

Looks like the second patch doesn't apply either.

Show
David Nolen added a comment - Looks like the second patch doesn't apply either.
Hide
Herwig Hochleitner added a comment -

Patch 0003 applies to current master

Show
Herwig Hochleitner added a comment - Patch 0003 applies to current master

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: