[#CLJS-418] Unspecified dependency on google-closure-library-third-party - Clojure JIRA

Details

Type: Defect
Status: Resolved
Priority: Major
Resolution: Completed
Affects Version/s: None
Fix Version/s: None
Component/s: None
Labels:
None

Description

Temporary fix to this issue: Add the G.Closure Library third-party extensions as a project dependency.

;; In :dependencies vector of Leiningen's project.clj
[org.clojure/google-closure-library-third-party "0.0-2029"]

But, as it turns out, various classes in the main library have explicit dependencies on things in the third-party extensions. See See also this G.Closure mailing list discussion.

As a result, the ClojureScript browser-connected REPL has a transitive dependency on the Google Closure Library third-party extensions. This manifests as an error in script/cljsc and a NullPointerException in lein-cljsbuild.

See the initial Clojure-dev mailing list discussion and discussion of this ticket.

Attachments

0001-CLJS-418-closure-r0.0-2029-2-specifies-dependency-on.patch

04/Dec/12 7:37 PM

2 kB

Herwig Hochleitner

Activity

Ascending order - Click to sort in descending order

Stuart Sierra made changes - 16/Nov/12 7:06 PM

Field	Original Value	New Value
Description	See [mailing list discussion\|https://groups.google.com/d/msg/clojure/kzzBoCZiAx0/W_wlfiSTMZgJ]. See also [lein-cljsbuild issue #155\|https://github.com/emezeske/lein-cljsbuild/issues/155].	We currently distribute the Google Closure Library in two separate JARs: the main library and the third-party extensions. See [Clojure-dev mailing list discussion\|https://groups.google.com/d/msg/clojure/kzzBoCZiAx0/W_wlfiSTMZgJ]. See also [lein-cljsbuild issue #155\|https://github.com/emezeske/lein-cljsbuild/issues/155]. See also this [G.Closure mailing list discussion\|https://groups.google.com/d/msg/closure-library-discuss/4DG-XJn0s4E/i7nlq84V41kJ]

Stuart Sierra made changes - 16/Nov/12 7:23 PM

Description	We currently distribute the Google Closure Library in two separate JARs: the main library and the third-party extensions. See [Clojure-dev mailing list discussion\|https://groups.google.com/d/msg/clojure/kzzBoCZiAx0/W_wlfiSTMZgJ]. See also [lein-cljsbuild issue #155\|https://github.com/emezeske/lein-cljsbuild/issues/155]. See also this [G.Closure mailing list discussion\|https://groups.google.com/d/msg/closure-library-discuss/4DG-XJn0s4E/i7nlq84V41kJ]	We currently distribute the Google Closure Library in two separate JARs: the main library and the third-party extensions. We do this because the third-party extensions are covered by different licenses. But, as it turns out, various classes in the main library have explicit dependencies on things in the third-party extensions. See See also this [G.Closure mailing list discussion\|https://groups.google.com/d/msg/closure-library-discuss/4DG-XJn0s4E/i7nlq84V41kJ]. As a result, the ClojureScript browser-connected REPL has a transitive dependency on the Google Closure Library third-party extensions. This manifests as an error in cljsbuild and a NullPointerException in lein-cljsbuild. See [Clojure-dev mailing list discussion\|https://groups.google.com/d/msg/clojure/kzzBoCZiAx0/W_wlfiSTMZgJ]. See also [lein-cljsbuild issue #155\|https://github.com/emezeske/lein-cljsbuild/issues/155]. It seems that the dependency on third-party extensions is unavoidable. There are several possible fixes: 1. Release a new G.Closure Library JAR with a declared dependency on the third-party extensions JAR. This best reflects the actual dependency relationships. 2. Release a new G.Closure Library JAR with the third-party extensions included in the JAR. This would make it harder to exclude the third-party licenses from projects which do not actually require them. 3. Release a new version of ClojureScript with a declared dependency on the third-party extensions JAR.
Assignee		Stuart Sierra [ stuart.sierra ]

Stuart Sierra made changes - 16/Nov/12 7:30 PM

Description

We currently distribute the Google Closure Library in two separate JARs: the main library and the third-party extensions. We do this because the third-party extensions are covered by different licenses.

But, as it turns out, various classes in the main library have explicit dependencies on things in the third-party extensions. See See also this [G.Closure mailing list discussion|https://groups.google.com/d/msg/closure-library-discuss/4DG-XJn0s4E/i7nlq84V41kJ].

As a result, the ClojureScript browser-connected REPL has a transitive dependency on the Google Closure Library third-party extensions. This manifests as an error in cljsbuild and a NullPointerException in lein-cljsbuild.

See [Clojure-dev mailing list discussion|https://groups.google.com/d/msg/clojure/kzzBoCZiAx0/W_wlfiSTMZgJ].

See also [lein-cljsbuild issue #155|https://github.com/emezeske/lein-cljsbuild/issues/155].

It seems that the dependency on third-party extensions is unavoidable. There are several possible fixes:

1. Release a new G.Closure Library JAR with a *declared dependency* on the third-party extensions JAR. This best reflects the *actual* dependency relationships.

2. Release a new G.Closure Library JAR with the third-party extensions included in the JAR. This would make it harder to exclude the third-party licenses from projects which do not actually require them.

3. Release a new version of ClojureScript with a declared dependency on the third-party extensions JAR.

We currently distribute the Google Closure Library in two separate JARs: the main library and the third-party extensions. We do this because the third-party extensions are covered by different licenses.

But, as it turns out, various classes in the main library have explicit dependencies on things in the third-party extensions. See See also this [G.Closure mailing list discussion|https://groups.google.com/d/msg/closure-library-discuss/4DG-XJn0s4E/i7nlq84V41kJ].

As a result, the ClojureScript browser-connected REPL has a transitive dependency on the Google Closure Library third-party extensions. This manifests as an error in script/cljsc and a NullPointerException in lein-cljsbuild.

See the [initial Clojure-dev mailing list discussion|https://groups.google.com/d/msg/clojure/kzzBoCZiAx0/W_wlfiSTMZgJ] and [discussion of this ticket|https://groups.google.com/d/msg/clojure/SFX4m0h6Z0g/gLLGOJFhSwsJ].

See also [lein-cljsbuild issue #155|https://github.com/emezeske/lein-cljsbuild/issues/155].

It seems that the dependency on third-party extensions is unavoidable. There are several possible fixes:

1. Release a new G.Closure Library JAR with a *declared dependency* on the third-party extensions JAR. This best reflects the *actual* dependency relationships.

2. Release a new G.Closure Library JAR with the third-party extensions included in the JAR. This would make it harder to exclude the third-party-licensed code from projects which do not actually require it.

3. Release a new version of ClojureScript with a declared dependency on the third-party extensions JAR. This makes the dependency more visible to ClojureScript developers.

Regardless of the approach taken, developers can always use explicit dependencies/exclusions to choose which version of the G.Closure library to include in their projects.

Stuart Sierra made changes - 16/Nov/12 7:32 PM

Description

We currently distribute the Google Closure Library in two separate JARs: the main library and the third-party extensions. We do this because the third-party extensions are covered by different licenses.

But, as it turns out, various classes in the main library have explicit dependencies on things in the third-party extensions. See See also this [G.Closure mailing list discussion|https://groups.google.com/d/msg/closure-library-discuss/4DG-XJn0s4E/i7nlq84V41kJ].

As a result, the ClojureScript browser-connected REPL has a transitive dependency on the Google Closure Library third-party extensions. This manifests as an error in script/cljsc and a NullPointerException in lein-cljsbuild.

See the [initial Clojure-dev mailing list discussion|https://groups.google.com/d/msg/clojure/kzzBoCZiAx0/W_wlfiSTMZgJ] and [discussion of this ticket|https://groups.google.com/d/msg/clojure/SFX4m0h6Z0g/gLLGOJFhSwsJ].

See also [lein-cljsbuild issue #155|https://github.com/emezeske/lein-cljsbuild/issues/155].

It seems that the dependency on third-party extensions is unavoidable. There are several possible fixes:

1. Release a new G.Closure Library JAR with a *declared dependency* on the third-party extensions JAR. This best reflects the *actual* dependency relationships.

2. Release a new G.Closure Library JAR with the third-party extensions included in the JAR. This would make it harder to exclude the third-party-licensed code from projects which do not actually require it.

3. Release a new version of ClojureScript with a declared dependency on the third-party extensions JAR. This makes the dependency more visible to ClojureScript developers.

Regardless of the approach taken, developers can always use explicit dependencies/exclusions to choose which version of the G.Closure library to include in their projects.

Temporary fix to this issue: Add the G.Closure Library third-party extensions as a project dependency.

{code}
;; In :dependencies vector of Leiningen's project.clj
[org.clojure/google-closure-library-third-party "0.0-2029"]
{code}

----

We currently distribute the Google Closure Library in two separate JARs: the main library and the third-party extensions. We do this because the third-party extensions are covered by different licenses.

But, as it turns out, various classes in the main library have explicit dependencies on things in the third-party extensions. See See also this [G.Closure mailing list discussion|https://groups.google.com/d/msg/closure-library-discuss/4DG-XJn0s4E/i7nlq84V41kJ].

As a result, the ClojureScript browser-connected REPL has a transitive dependency on the Google Closure Library third-party extensions. This manifests as an error in script/cljsc and a NullPointerException in lein-cljsbuild.

See the [initial Clojure-dev mailing list discussion|https://groups.google.com/d/msg/clojure/kzzBoCZiAx0/W_wlfiSTMZgJ] and [discussion of this ticket|https://groups.google.com/d/msg/clojure/SFX4m0h6Z0g/gLLGOJFhSwsJ].

See also [lein-cljsbuild issue #155|https://github.com/emezeske/lein-cljsbuild/issues/155].

It seems that the dependency on third-party extensions is unavoidable. There are several possible fixes:

1. Release a new G.Closure Library JAR with a *declared dependency* on the third-party extensions JAR. This best reflects the *actual* dependency relationships.

2. Release a new G.Closure Library JAR with the third-party extensions included in the JAR. This would make it harder to exclude the third-party-licensed code from projects which do not actually require it.

3. Release a new version of ClojureScript with a declared dependency on the third-party extensions JAR. This makes the dependency more visible to ClojureScript developers.

Regardless of the approach taken, developers can always use explicit dependencies/exclusions to choose which version of the G.Closure library to include in their projects.

Hide

Permalink

Herwig Hochleitner added a comment - 04/Dec/12 7:10 PM

Attached patch implements option 1

The generated closure-library depends on the old clojure-library-third-party.
Still, I would recommend releasing the -2 version of third-party too, in case someone includes third-party by c&p the library version.

Show

Herwig Hochleitner added a comment - 04/Dec/12 7:10 PM Attached patch implements option 1 The generated closure-library depends on the old clojure-library-third-party. Still, I would recommend releasing the -2 version of third-party too, in case someone includes third-party by c&p the library version.

Herwig Hochleitner made changes - 04/Dec/12 7:10 PM

Attachment

0001-CLJS-418-closure-r0.0-2029-2-specifies-dependency-on.patch [ 11745 ]

Herwig Hochleitner made changes - 04/Dec/12 7:37 PM

Attachment

0001-~~CLJS-418~~-closure-r0.0-2029-2-specifies-dependency-on.patch [ 11745 ]

Herwig Hochleitner made changes - 04/Dec/12 7:37 PM

Attachment

0001-CLJS-418-closure-r0.0-2029-2-specifies-dependency-on.patch [ 11746 ]

Hide

Permalink

Evan Mezeske added a comment - 16/Dec/12 8:29 PM

I added a workaround for this so that I can release lein-cljsbuild without breaking every single project that uses it: https://github.com/emezeske/lein-cljsbuild/issues/163 .

I would like to revert this workaround ASAP. I'm going to do a bad job of maintaining the right version of the third party libraries, and it will cause problems down the road.

Show

Evan Mezeske added a comment - 16/Dec/12 8:29 PM I added a workaround for this so that I can release lein-cljsbuild without breaking every single project that uses it: https://github.com/emezeske/lein-cljsbuild/issues/163 . I would like to revert this workaround ASAP. I'm going to do a bad job of maintaining the right version of the third party libraries, and it will cause problems down the road.

Hide

Permalink

Chas Emerick added a comment - 27/Jan/13 5:37 PM

Option 1 is proper, 3 is acceptable. Any solution will do though; drove myself nuts with this today for longer than I'd like to admit before I discovered this ticket.

Show

Chas Emerick added a comment - 27/Jan/13 5:37 PM Option 1 is proper, 3 is acceptable. Any solution will do though; drove myself nuts with this today for longer than I'd like to admit before I discovered this ticket.

Hide

Permalink

David Nolen added a comment - 27/Jan/13 5:41 PM

Is everyone cool with option 1? It would be nice to resolve this one soon as people are running into non-working browser REPLs.

Show

David Nolen added a comment - 27/Jan/13 5:41 PM Is everyone cool with option 1? It would be nice to resolve this one soon as people are running into non-working browser REPLs.

Hide

Permalink

Michał Marczyk added a comment - 27/Jan/13 7:29 PM

+1 for option 1.

Show

Michał Marczyk added a comment - 27/Jan/13 7:29 PM +1 for option 1.

Hide

Permalink

Stuart Sierra added a comment - 03/Feb/13 3:50 PM - edited

Deployed new version of Google Closure library to Sonatype OSS today. Please try it out.

[org.clojure/google-closure-library "0.0-2029-2"]

This release declares an explicit dependency from google-closure-library on google-closure-library-third-party (Option 1 in the ticket description).

It will be available in the Maven Central repository within 24 hours. Until then, you can get it from the Sonatype repository with these instructions:
http://dev.clojure.org/display/doc/Maven+Settings+and+Repositories

If it works, we can update the ClojureScript POM to depend on it.

-S

Show

Stuart Sierra added a comment - 03/Feb/13 3:50 PM - edited Deployed new version of Google Closure library to Sonatype OSS today. Please try it out.

[org.clojure/google-closure-library "0.0-2029-2"]

This release declares an explicit dependency from google-closure-library on google-closure-library-third-party (Option 1 in the ticket description). It will be available in the Maven Central repository within 24 hours. Until then, you can get it from the Sonatype repository with these instructions: http://dev.clojure.org/display/doc/Maven+Settings+and+Repositories If it works, we can update the ClojureScript POM to depend on it. -S

Hide

Permalink

Stuart Sierra added a comment - 16/Feb/13 2:59 PM

pom.template updated in commit f2e0d9050a1b

Show

Stuart Sierra added a comment - 16/Feb/13 2:59 PM pom.template updated in commit f2e0d9050a1b

Stuart Sierra made changes - 16/Feb/13 2:59 PM

Resolution		Completed [ 1 ]
Status	Open [ 1 ]	Resolved [ 5 ]

People

Assignee:

Stuart Sierra

Reporter:

Stuart Sierra

Vote (3)

Watch (3)

Dates

Created:

16/Nov/12 6:50 PM

Updated:

16/Feb/13 2:59 PM

Resolved:

16/Feb/13 2:59 PM