ClojureScript

copy cond-> etc from 1.5

Details

  • Type: Enhancement Enhancement
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Patch:
    Code

Description

Attached patch (cljs-438-condetc.patch, 11 Dec 2012) copies cond->, cond->>, as->, some->, and some->> from 1.5 master. This lets ClojureScript users use these macros without requiring Clojure 1.5.

I suppose this maybe should wait until 1.5.0 is out, in case another renaming occurs.

Another way to do this would be to have import-macros ignore missing macros and add these there. Then the macros would only be available for users requiring Clojure 1.5 (which.. makes sense), and we wouldn't have to copy them.

Activity

Descending order - Click to sort in ascending order
Hide
Permalink
Tom Jack added a comment - - edited

Here's the patch I think you want. It applies to master and assumes 1.5. (CLJS-438_2012-03-16.patch)

Show
Tom Jack added a comment - - edited Here's the patch I think you want. It applies to master and assumes 1.5. (CLJS-438_2012-03-16.patch)
Hide
Permalink
Tom Jack added a comment -

You want the patch as is, copying the macros from 1.5? I assumed we'd move to 1.5 and then we can just add cond-> etc to the import-macros call.

Show
Tom Jack added a comment - You want the patch as is, copying the macros from 1.5? I assumed we'd move to 1.5 and then we can just add cond-> etc to the import-macros call.
Hide
Permalink
David Nolen added a comment -

Can we get an updated version of this patch that applies to master? Thanks!

Show
David Nolen added a comment - Can we get an updated version of this patch that applies to master? Thanks!
Hide
Permalink
David Nolen added a comment -

Is this patch up-to-date? Seems like 1.5 is just around the corner.

Show
David Nolen added a comment - Is this patch up-to-date? Seems like 1.5 is just around the corner.
Hide
Permalink
Tom Jack added a comment -

Sounds good.

Show
Tom Jack added a comment - Sounds good.
Hide
Permalink
David Nolen added a comment -

I'm inclined to hold off on this one since 1.5 is so close. As soon as 1.5 becomes official I'd like to make it a requirement for ClojureScript - as then I can merge the source-map branch and hopefully get some help on that work.

Show
David Nolen added a comment - I'm inclined to hold off on this one since 1.5 is so close. As soon as 1.5 becomes official I'd like to make it a requirement for ClojureScript - as then I can merge the source-map branch and hopefully get some help on that work.

People

  • Assignee:
    Unassigned
    Reporter:
    Tom Jack
Vote (0)
Watch (3)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4#649-r158309) | Report a problem
Powered by a free Atlassian JIRA open source license for Clojure. Try JIRA - bug tracking software for your team.