[#CLJS-461] repeated assoc into map eventually drops meta data - Clojure JIRA

Details

Type: Defect
Status: Resolved
Priority: Major
Resolution: Completed
Affects Version/s: None
Fix Version/s: None
Component/s: None
Labels:
None
Environment:
[org.clojure/clojurescript "0.0-1552"]

Description

When running this loop, then the map's meta is lost after 32 assocs:

(loop [i 0, m (with-meta {} {:foo :bar})]
  (when (<= i 34)
    (.log js/console i (pr-str (meta m)))
    (recur (inc i) (assoc m (str i) i))))

The last 4 lines of output read

31 {:foo :bar}
  32 {:foo :bar}
  33 nil
  34 nil

cljs.core.ObjMap/HASHMAP_THRESHOLD happens to be 32, so I guess
there is a connection.

More Options
- Sort By Name
- Sort By Date
- Ascending
- Descending
- Download All

Attachments

0001-CLJS-461-preserve-metadata-on-automatic-map-conversi.patch

26/Jan/13 10:20 PM

3 kB

Michał Marczyk

Activity

Ascending order - Click to sort in descending order

Michał Marczyk made changes - 24/Jan/13 12:38 AM

Field	Original Value	New Value
Assignee		Michał Marczyk [ michalmarczyk ]

Michał Marczyk made changes - 24/Jan/13 12:50 AM

Attachment

0001-CLJS-461-preserve-metadata-on-automatic-ObjMap-to-PH.patch [ 11815 ]

Hide

Permalink

Michał Marczyk added a comment - 24/Jan/13 12:51 AM

obj-map->hash-map failed to take into account the fact that transients don't support metadata. The attached patch fixes this.

Show

Michał Marczyk added a comment - 24/Jan/13 12:51 AM obj-map->hash-map failed to take into account the fact that transients don't support metadata. The attached patch fixes this.

Hide

Permalink

Michał Marczyk added a comment - 25/Jan/13 6:11 AM

Just realized that this also happens with PAMs. New patch addresses the issue in both places. (Also tweaks the PAM->PHM conversion – no more transient creation for a single assoc.)

Show

Michał Marczyk added a comment - 25/Jan/13 6:11 AM Just realized that this also happens with PAMs. New patch addresses the issue in both places. (Also tweaks the PAM->PHM conversion – no more transient creation for a single assoc.)

Michał Marczyk made changes - 25/Jan/13 6:11 AM

Attachment

0001-CLJS-461-preserve-metadata-on-automatic-map-conversi.patch [ 11816 ]

Michał Marczyk made changes - 25/Jan/13 6:12 AM

Attachment

0001-~~CLJS-461~~-preserve-metadata-on-automatic-ObjMap-to-PH.patch [ 11815 ]

David Nolen made changes - 26/Jan/13 11:05 AM

Description

When running this loop, then the map's meta is lost after 32 assocs:

  (loop [i 0, m (with-meta {} {:foo :bar})]
    (when (<= i 34)
      (.log js/console i (pr-str (meta m)))
      (recur (inc i) (assoc m (str i) i))))

The last 4 lines of output read

  31 {:foo :bar}
  32 {:foo :bar}
  33 nil
  34 nil

cljs.core.ObjMap/HASHMAP_THRESHOLD happens to be 32, so I guess
there is a connection.

When running this loop, then the map's meta is lost after 32 assocs:

{code}
(loop [i 0, m (with-meta {} {:foo :bar})]
  (when (<= i 34)
    (.log js/console i (pr-str (meta m)))
    (recur (inc i) (assoc m (str i) i))))
{code}

The last 4 lines of output read

{code}
  31 {:foo :bar}
  32 {:foo :bar}
  33 nil
  34 nil
{code}

cljs.core.ObjMap/HASHMAP_THRESHOLD happens to be 32, so I guess
there is a connection.

Hide

Permalink

David Nolen added a comment - 26/Jan/13 11:06 AM

I tried the patch and it did not seem to resolve the case above. Could we get a patch that includes a test case? Thanks!

Show

David Nolen added a comment - 26/Jan/13 11:06 AM I tried the patch and it did not seem to resolve the case above. Could we get a patch that includes a test case? Thanks!

Hide

Permalink

Michał Marczyk added a comment - 26/Jan/13 10:13 PM

I tried it again at a Rhino REPL and for me it resolves both problems (OM and PAM). New patch with test cases based on the form from the ticket attached. (The tests do fail on master.)

Show

Michał Marczyk added a comment - 26/Jan/13 10:13 PM I tried it again at a Rhino REPL and for me it resolves both problems (OM and PAM). New patch with test cases based on the form from the ticket attached. (The tests do fail on master.)

Michał Marczyk made changes - 26/Jan/13 10:13 PM

Attachment

0005-CLJS-461-preserve-metadata-on-automatic-map-conversi.patch [ 11819 ]

Michał Marczyk made changes - 26/Jan/13 10:13 PM

Attachment

0005-~~CLJS-461~~-preserve-metadata-on-automatic-map-conversi.patch [ 11819 ]

Michał Marczyk made changes - 26/Jan/13 10:13 PM

Attachment

0001-~~CLJS-461~~-preserve-metadata-on-automatic-map-conversi.patch [ 11816 ]

Michał Marczyk made changes - 26/Jan/13 10:14 PM

Attachment

0001-CLJS-461-preserve-metadata-on-automatic-map-conversi.patch [ 11820 ]