ClojureScript

Records are printed without namespace

Details

  • Type: Defect Defect
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Environment:
    Any
  • Patch:
    Code and Test

Description

When printing a Record it is currently printed without the proper namespace.

(ns dummy)
(defrecord Foo [bar])
(pr-str (Foo. "bar"))

will print as "#dummy.Foo{..." in CLJ but "#Foo{..." in CLJS.

The attached patch fixes the implementation as well as the "incorrect" test.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
David Nolen added a comment -

Thanks, have you submitted your CA?

Show
David Nolen added a comment - Thanks, have you submitted your CA?
Hide
Permalink
Thomas Heller added a comment -

Will do ASAP, I'm in Germany so its probably gonna take a week or so.

Show
Thomas Heller added a comment - Will do ASAP, I'm in Germany so its probably gonna take a week or so.
Hide
Permalink
David Nolen added a comment -

This patch was not properly created. Please follow the example demonstrated here - http://ariejan.net/2009/10/26/how-to-create-and-apply-a-patch-with-git

Show
David Nolen added a comment - This patch was not properly created. Please follow the example demonstrated here - http://ariejan.net/2009/10/26/how-to-create-and-apply-a-patch-with-git
Hide
Permalink
Thomas Heller added a comment -

Patch updated.

I sent me CA over 2 weeks ago, should I assume it was lost and try again or does it usually take this long?

Show
Thomas Heller added a comment - Patch updated. I sent me CA over 2 weeks ago, should I assume it was lost and try again or does it usually take this long?
Hide
Permalink
David Nolen added a comment -

Fixed, http://github.com/clojure/clojurescript/commit/8aa0cd7a0ba3f8466fcde83558ce83f275b61b32

It looks like your CA made it just fine, thank you very much for the contribution!

Show
David Nolen added a comment - Fixed, http://github.com/clojure/clojurescript/commit/8aa0cd7a0ba3f8466fcde83558ce83f275b61b32 It looks like your CA made it just fine, thank you very much for the contribution!
Hide
Permalink
Thomas Heller added a comment -

Ah, awesome. Thanks.

Show
Thomas Heller added a comment - Ah, awesome. Thanks.

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4#649-r158309) | Report a problem
Powered by a free Atlassian JIRA open source license for Clojure. Try JIRA - bug tracking software for your team.