ClojureScript

Constant literal optimization

Details

  • Type: Enhancement Enhancement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

We should optimize constant literals, in particular keywords. This optimization means that we will have to decide whether to make identical? slower by testing for keywords (this means it's probably a bad idea to continue to inline it) or to provide a special keyword-identical? that does the right thing.

Activity

Hide
David Nolen added a comment -

this was completed long ago for keywords & symbols - other data structures can be handled by separate issue.

Show
David Nolen added a comment - this was completed long ago for keywords & symbols - other data structures can be handled by separate issue.
Hide
Sean Grove added a comment -

There's another interesting twist while using piggieback + brepl that relates to a missing constants_table.js. Not sure what causes it (haven't found a way to repro), but only happens in a few circumstances, so the repl still mainly works.

The runtime part continues to works fine however.

Show
Sean Grove added a comment - There's another interesting twist while using piggieback + brepl that relates to a missing constants_table.js. Not sure what causes it (haven't found a way to repro), but only happens in a few circumstances, so the repl still mainly works. The runtime part continues to works fine however.
Hide
Sean Grove added a comment -

This is related to the reified keywords in cljs, see http://dev.clojure.org/jira/browse/CLJS-576

Show
Sean Grove added a comment - This is related to the reified keywords in cljs, see http://dev.clojure.org/jira/browse/CLJS-576

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: