ClojureScript

Switch to tools.reader for cljs.analyzer/forms-seq

Details

  • Type: Enhancement Enhancement
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Environment:
    CLJS master
  • Patch:
    Code

Description

Switches cljs.analyzer to use tools.reader, so we can get more accurate column location for symbols, prepping for more fleshed-out source maps.

Activity

David Nolen made changes -
Field Original Value New Value
Priority Minor [ 4 ] Major [ 3 ]
Hide
David Nolen added a comment -

Excellent, we need two more things in this patch, can you update bootstrap.sh and the POM file? Thanks.

Show
David Nolen added a comment - Excellent, we need two more things in this patch, can you update bootstrap.sh and the POM file? Thanks.
Hide
Sean Grove added a comment -

Updated with POM information and bootstrap update

Show
Sean Grove added a comment - Updated with POM information and bootstrap update
Sean Grove made changes -
Attachment use_tools_reader.patch [ 12065 ]
Hide
Sean Grove added a comment -

CA's been processed and I'm listed on the contributing page, so shouldn't be blocked by that any longer.

Show
Sean Grove added a comment - CA's been processed and I'm listed on the contributing page, so shouldn't be blocked by that any longer.
Hide
David Nolen added a comment -

I tried applying this patch and rerunning the bootstrap script. This works but when I try to run script/test I get an error about the tools.reader not being on the classpath. Even trying to require tools.reader at via the repl doesn't work for me.

Show
David Nolen added a comment - I tried applying this patch and rerunning the bootstrap script. This works but when I try to run script/test I get an error about the tools.reader not being on the classpath. Even trying to require tools.reader at via the repl doesn't work for me.
Sean Grove made changes -
Sean Grove made changes -
Attachment use_tools_reader.patch [ 12065 ]
Sean Grove made changes -
Attachment use_tools_reader.patch [ 12064 ]
David Nolen made changes -
Resolution Completed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
David Nolen made changes -
Status Resolved [ 5 ] Closed [ 6 ]

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: