ClojureScript

Aliasing exception when using require-macros

Details

  • Type: Defect Defect
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

When using require-macros with a namespace defining an alias, redefining this alias locally will fail.
This scenario is probably more frequent with library targeting both Clojure and ClojureScript.

I have a reproducing example here.

I also get the same issue without the require-macros when both clj/cljs files are in the same folder. Not sure if this is supported and/or an issue in lein-cljsbuild.

Activity

Hide
David Nolen added a comment -

Hrm, I wonder if we can actually solve this problem, we need to construct namespaces in Clojure so that the reader can resolve keywords, etc.

Show
David Nolen added a comment - Hrm, I wonder if we can actually solve this problem, we need to construct namespaces in Clojure so that the reader can resolve keywords, etc.
Hide
David Nolen added a comment -

Was this resolved by CLJS-605?

Show
David Nolen added a comment - Was this resolved by CLJS-605?
Hide
Julien Eluard added a comment -

Assuming the patch for CLJS-605 is in release 1913, no. I still get the same error message.

Show
Julien Eluard added a comment - Assuming the patch for CLJS-605 is in release 1913, no. I still get the same error message.
Hide
David Nolen added a comment -

No CLJS-605 is fixed in master and not available in a release yet. If you have time to test it out that would be great, if not please let us know when we push out the next release. Thanks!

Show
David Nolen added a comment - No CLJS-605 is fixed in master and not available in a release yet. If you have time to test it out that would be great, if not please let us know when we push out the next release. Thanks!
Hide
Julien Eluard added a comment -

Still get an error with latest master (1918) but now with a slightly different stacktrace. I updated my gist with the new trace.

Show
Julien Eluard added a comment - Still get an error with latest master (1918) but now with a slightly different stacktrace. I updated my gist with the new trace.
Hide
David Nolen added a comment -

Is this still a problem given the latest tools.reader?

Show
David Nolen added a comment - Is this still a problem given the latest tools.reader?
Hide
Julien Eluard added a comment -

No, it now works fine with 2123. Thanks!

Show
Julien Eluard added a comment - No, it now works fine with 2123. Thanks!

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: