ClojureScript

Misleading message when calling a multi method resulting in a miss

Details

  • Type: Defect Defect
  • Status: Closed Closed
  • Priority: Trivial Trivial
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

When calling a multimethod with no method matching the dispatching value an exception with a misleading message is thrown.
This is due to the usage of a name argument not part of the associated method definition, resulting to the code of cljs.core/name to be printed instead.

Provided patches fixes this by specifying the name argument.

Activity

Julien Eluard made changes -
Field Original Value New Value
Description When calling a multimethod with no method matching the dispatching value an exception with a misleading message is thrown.
This is due to the usage of a _name_ argument not part of the associated [method definition|https://github.com/clojure/clojurescript/blob/master/src/cljs/cljs/core.cljs#L7372], resulting to the code of cljs.core/name to be printed instead.

Provided patches fixes this by specifying the name argument.
When calling a multimethod with no method matching the dispatching value an exception with a misleading message is thrown.
This is due to the usage of a _name_ argument not part of the associated [method definition|https://github.com/clojure/clojurescript/blob/master/src/cljs/cljs/core.cljs#L7370], resulting to the code of cljs.core/name to be printed instead.

Provided patches fixes this by specifying the name argument.
Hide
Julien Eluard added a comment -

It looks like this patch would be a quick win. Anything I can do to help move it forward?

Show
Julien Eluard added a comment - It looks like this patch would be a quick win. Anything I can do to help move it forward?
Julien Eluard made changes -
Issue Type Enhancement [ 4 ] Defect [ 1 ]
David Nolen made changes -
Resolution Completed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
David Nolen made changes -
Status Resolved [ 5 ] Closed [ 6 ]
Hide
David Nolen added a comment -

In future it's nice to have the ticket number in the description of the patch so when cutting releases it's easier to browse the commit history for figuring which bugs got squashed.

Thanks again!

Show
David Nolen added a comment - In future it's nice to have the ticket number in the description of the patch so when cutting releases it's easier to browse the commit history for figuring which bugs got squashed. Thanks again!

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: