ClojureScript

(keyword :x) produces ::x

Details

  • Type: Defect Defect
  • Status: Closed Closed
  • Priority: Major Major
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None
  • Patch:
    Code and Test

Description

I encountered this bug via a macro with (map keyword syms). (keyword :x) produces ::x, (keyword (keyword :x)) produces :::x, etc. Also, it might be worth mentioning (identical? :x (keyword :x)) and (identical? :x (keyword "x")) both fail.

Activity

Hide
Joel Holdbrooks added a comment -

I should point out this patch resolves the issue with (identical? :x (keyword :x)) but not (identical? :x (keyword "x")).

Show
Joel Holdbrooks added a comment - I should point out this patch resolves the issue with (identical? :x (keyword :x)) but not (identical? :x (keyword "x")).
Joel Holdbrooks made changes -
Field Original Value New Value
Attachment cljs_keyword_keyword.patch [ 12279 ]
Joel Holdbrooks made changes -
Attachment cljs_599.patch [ 12280 ]
Hide
Ben Moss added a comment - - edited

Seems like this was introduced with https://github.com/clojure/clojurescript/commit/2cef52840fcd9d88f077d374cc81e50c7e645b9f. Previously the `keyword` function would do what is done in the patch.

Show
Ben Moss added a comment - - edited Seems like this was introduced with https://github.com/clojure/clojurescript/commit/2cef52840fcd9d88f077d374cc81e50c7e645b9f. Previously the `keyword` function would do what is done in the patch.
Hide
David Nolen added a comment - - edited

Thanks for the report! In order to take patches we need contributors to fill out and submit a CA. http://clojure.org/contributing

Show
David Nolen added a comment - - edited Thanks for the report! In order to take patches we need contributors to fill out and submit a CA. http://clojure.org/contributing
David Nolen made changes -
Resolution Completed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
David Nolen made changes -
Status Resolved [ 5 ] Closed [ 6 ]
Hide
Joel Holdbrooks added a comment -

Thanks David! Looks like I've gotta get something in the mail!

Show
Joel Holdbrooks added a comment - Thanks David! Looks like I've gotta get something in the mail!

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: