ClojureScript

• Type: Defect
• Status: Closed
• Priority: Minor
• Resolution: Completed
• Affects Version/s: None
• Fix Version/s: None
• Component/s: None
• Labels:

  • keywords
• Environment:

  cljs r1978

In Clojurescript, keyword called with a single non-keyword argument always produces a nil-namespace keyword. This is inconsistent with Clojure (although the clojure docs don't mention anything about parsing strings for namespaces).

(-> 'a.b keyword ((juxt namespace name)))
;=> [nil "a.b"]
(-> 'a.b/c keyword ((juxt namespace name)))
;=> ["a.b" "c"]
(-> "a.b" keyword ((juxt namespace name)))
;=> [nil "a.b"]
(-> "a.b/c" keyword ((juxt namespace name)))
;=> ["a.b" "c"]
(-> "/c" keyword ((juxt namespace name)))
;=> ["" "c"]
(-> (symbol "/c") keyword ((juxt namespace name)))
;=> ["" "c"]

Compare with cljs:

(-> 'a.b keyword ((juxt namespace name)))
;=> [nil "a.b"]
(-> 'a.b/c keyword ((juxt namespace name)))
;=> [nil "c"]
(-> "a.b" keyword ((juxt namespace name)))
;=> [nil "a.b"]
(-> "a.b/c" keyword ((juxt namespace name)))
;=> [nil "a.b/c"]
(-> "/c" keyword ((juxt namespace name)))
;=> [nil "/c"]
(-> (symbol "/c") keyword ((juxt namespace name)))
;=> [nil "/c"]

Suggested (untested) patch:

(defn keyword
  "Returns a Keyword with the given namespace and name.  Do not use :
  in the keyword strings, it will be added automatically."
  ([name] (cond
            (keyword? name) name
            (symbol? name) (Keyword. (namespace name) (cljs.core/name name)
                                     (str name) nil)
            (string? name) (let [idx (.indexOf name "/")
                                 [ns n] (if (= -1 idx)
                                          [nil name]
                                          [(subs name 0 idx) (subs name idx)])]
                             (Keyword. ns n name nil))
            :else (Keyword. nil name name nil)))
  ([ns name] (Keyword. ns name (str (when ns (str ns "/")) name) nil)))

• Assignee:

  Unassigned

  Reporter:

  Francis Avila

• Created:

  04/Nov/13 5:24 PM

  Updated:

  09/Nov/13 3:38 PM

  Resolved:

  09/Nov/13 3:37 PM