ClojureScript

script/bootstrap downloads unspecified version of closure-compiler

Details

  • Type: Defect Defect
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Declined
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

script/bootstrap downloads http://dl.google.com/closure-compiler/compiler-latest.zip (https://github.com/clojure/clojurescript/blob/r2080/script/bootstrap#L64), while the project.clj specifies a specific version.

As a result, you'll get a different version of the compiler when using following the Quick Start guide. The latest version of the Closure Compiler was compiled for Java 7, causing cljsc to fail with a java.lang.UnsupportedClassVersionError under Java 6.

Activity

Hide
David Nolen added a comment -

Does Closure Compiler no longer support Java 6?

Show
David Nolen added a comment - Does Closure Compiler no longer support Java 6?
Hide
Ryan Berdeen added a comment - - edited

The release notes for v20131118 say "Move compiler to Java 7": https://groups.google.com/d/topic/closure-compiler-discuss/_T5Aai2sg68/discussion.

This release can still be built for Java 6 using ant jar -Dant.build.javac.source=1.6 -Dant.build.javac.target=1.6, but the current master makes use of Java 7 features in one class.

The Java 6/Java 7 support seems like it should be it's own issue. It's just how I discovered the problem, which is that running the bootstrap script doesn't give a consistent result. All of the other dependencies apart from closure-compiler have explicitly set versions, so I'm not sure I understand the reasoning. Shouldn't it download from central.maven.org with a version that matches project.clj?

Show
Ryan Berdeen added a comment - - edited The release notes for v20131118 say "Move compiler to Java 7": https://groups.google.com/d/topic/closure-compiler-discuss/_T5Aai2sg68/discussion. This release can still be built for Java 6 using ant jar -Dant.build.javac.source=1.6 -Dant.build.javac.target=1.6, but the current master makes use of Java 7 features in one class. The Java 6/Java 7 support seems like it should be it's own issue. It's just how I discovered the problem, which is that running the bootstrap script doesn't give a consistent result. All of the other dependencies apart from closure-compiler have explicitly set versions, so I'm not sure I understand the reasoning. Shouldn't it download from central.maven.org with a version that matches project.clj?
Hide
David Nolen added a comment -

project.clj is just a convenience for people actually hacking on the compiler for now.

Show
David Nolen added a comment - project.clj is just a convenience for people actually hacking on the compiler for now.
Hide
David Nolen added a comment -

We simply stay abreast of the Closure Compiler.

Show
David Nolen added a comment - We simply stay abreast of the Closure Compiler.
David Nolen made changes -
Field Original Value New Value
Resolution Completed [ 1 ]
Status Open [ 1 ] Resolved [ 5 ]
David Nolen made changes -
Status Resolved [ 5 ] Closed [ 6 ]
David Nolen made changes -
Status Closed [ 6 ] Reopened [ 4 ]
Resolution Completed [ 1 ]
David Nolen made changes -
Resolution Declined [ 2 ]
Status Reopened [ 4 ] Resolved [ 5 ]
David Nolen made changes -
Status Resolved [ 5 ] Closed [ 6 ]

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: